Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XML Resource Property isDisplayedFor #3034

Merged
merged 1 commit into from
Feb 19, 2018

Conversation

ron-murhammer
Copy link
Member

Addresses portion of https://forums.triplea-game.org/topic/558/fuel-enhancements

Functional Changes

  • Added new isDisplayFor property for resources which can be "NONE" or list of players (defaults to showing for all players). Primarily used to display/hide certain resources for specific nations. Follows up the changes in Add Player Resource Bar #3013 .

Example

  <resourceList>
    <resource name="techTokens" isDisplayedFor="NONE"/>
    <resource name="PUs" isDisplayedFor="Union"/>
    <resource name="Manpower" isDisplayedFor="Confederate"/>
    <resource name="Supplies" isDisplayedFor="Union:Confederate"/>
    <resource name="Industry"/>
    <resource name="Leadership"/>
  </resourceList>

@codecov-io
Copy link

Codecov Report

Merging #3034 into master will increase coverage by <.01%.
The diff coverage is 25.8%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3034      +/-   ##
============================================
+ Coverage     20.53%   20.54%   +<.01%     
- Complexity     5817     5818       +1     
============================================
  Files           819      819              
  Lines         72917    72935      +18     
  Branches      12010    12014       +4     
============================================
+ Hits          14973    14982       +9     
- Misses        55854    55863       +9     
  Partials       2090     2090
Impacted Files Coverage Δ Complexity Δ
...in/java/games/strategy/triplea/ui/ResourceBar.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...in/java/games/strategy/engine/data/GameParser.java 69.43% <33.33%> (-0.84%) 175 <2> (-1)
...main/java/games/strategy/engine/data/Resource.java 83.33% <75%> (-16.67%) 2 <1> (+1)
.../src/main/java/games/strategy/net/nio/Decoder.java 72.82% <0%> (-1.09%) 24% <0%> (-1%)
...rc/main/java/games/strategy/net/nio/NioWriter.java 68.64% <0%> (+1.69%) 20% <0%> (ø) ⬇️
.../java/games/strategy/engine/data/DefaultNamed.java 66.66% <0%> (+22.22%) 7% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 375173e...19c3bf5. Read the comment docs.

@RoiEXLab RoiEXLab deleted the Add_isDisplayedFor_Resource_Property branch February 19, 2018 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants