Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI - Add support for placing triggered sea units #3542

Merged
merged 1 commit into from
Jul 12, 2018

Conversation

ron-murhammer
Copy link
Member

Addresses feedback here: https://forums.triplea-game.org/topic/105/ai-development-discussion-and-feedback/97

The AI will now try to place any remaining sea units (previously only tried to place land/air).

@codecov-io
Copy link

Codecov Report

Merging #3542 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3542      +/-   ##
============================================
- Coverage     21.98%   21.97%   -0.01%     
+ Complexity     5922     5919       -3     
============================================
  Files           838      838              
  Lines         71991    72000       +9     
  Branches      11551    11553       +2     
============================================
- Hits          15828    15824       -4     
- Misses        54075    54086      +11     
- Partials       2088     2090       +2
Impacted Files Coverage Δ Complexity Δ
...a/games/strategy/triplea/ai/pro/ProPurchaseAi.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...rategy/triplea/attachments/UnitTypeComparator.java 46.15% <0%> (-7.7%) 12% <0%> (-1%)
.../strategy/triplea/odds/calculator/DummyPlayer.java 35.22% <0%> (-1.14%) 9% <0%> (-1%)
.../src/main/java/games/strategy/net/nio/Decoder.java 72.82% <0%> (-1.09%) 24% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a11e3cb...a7af88a. Read the comment docs.

@ron-murhammer
Copy link
Member Author

Merging as minor AI change so it can be tested.

@ron-murhammer ron-murhammer merged commit 10b9bce into master Jul 12, 2018
@ron-murhammer ron-murhammer changed the title Add support for placing triggered sea units AI - Add support for placing triggered sea units Jul 12, 2018
@DanVanAtta DanVanAtta deleted the AI_Place_Triggered_Sea_Units branch July 16, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants