Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to remove isSuicide units from air landing on carrier checks #4322

Merged
merged 2 commits into from
Nov 6, 2018

Conversation

ron-murhammer
Copy link
Member

Addresses: https://forums.triplea-game.org/topic/73/iron-war-official-thread/395

When checking for valid carrier landing locations for air units, isSuicide air units which are attacking should be ignored (missiles, bombs, etc). This only impacts a few advanced maps which use these types of units (Iron War being the one the issue was reported on and the fix was tested on).

@codecov-io
Copy link

Codecov Report

Merging #4322 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4322      +/-   ##
============================================
+ Coverage     22.62%   22.67%   +0.04%     
- Complexity     6099     6112      +13     
============================================
  Files           868      868              
  Lines         71138    71154      +16     
  Branches      11356    11360       +4     
============================================
+ Hits          16097    16132      +35     
+ Misses        53003    52982      -21     
- Partials       2038     2040       +2
Impacted Files Coverage Δ Complexity Δ
...trategy/triplea/delegate/AirMovementValidator.java 74.3% <100%> (+0.26%) 81 <0> (+2) ⬆️
...me-core/src/main/java/games/strategy/net/GUID.java 88.57% <0%> (+1.61%) 14% <0%> (+3%) ⬆️
.../games/strategy/engine/ClientFileSystemHelper.java 57.5% <0%> (+2.5%) 11% <0%> (+1%) ⬆️
...gy/engine/framework/map/download/DownloadFile.java 52.17% <0%> (+15.21%) 11% <0%> (+2%) ⬆️
...engine/framework/map/download/FileSizeWatcher.java 85.71% <0%> (+85.71%) 5% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eefa128...5bb55bd. Read the comment docs.

Copy link
Member

@RoiEXLab RoiEXLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable 👍

@RoiEXLab RoiEXLab merged commit 5e5404f into master Nov 6, 2018
@DanVanAtta DanVanAtta deleted the Fix_Carrier_Air_Validation_For_IsSuicide branch November 9, 2018 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants