Fix lobby menu & Use Menu Builder

[DanVanAtta]

Overview

• Refactoring mistake added the sound options to the main lobby menu rather than the settings submenu. Commit (1) fixes this: 7097918

• Commit (2) refactors the lobby menu to use the builder API. This reduces a lot of the boiler plate code and makes it very difficult to add sub-menu's to the wrong menu.

Functional Changes

[ ] New map or map update
[ ] New Feature
[ ] Feature update or enhancement
[ ] Feature Removal
[x] Code Cleanup or refactor
[ ] Configuration Change
[x] Bug fix

Testing

[ ] Covered by existing automated tests
[ ] Covered by newly added automated tests
[x] Manually tested
[ ] No testing done

Launched local lobby and connected to it locally to verify the menu.

Screens Shots

Before

After

[codecov-io]

Codecov Report

Merging #5188 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #5188      +/-   ##
============================================
+ Coverage     24.08%   24.09%   +0.01%     
- Complexity     6763     6765       +2     
============================================
  Files          1016     1016              
  Lines         77836    77802      -34     
  Branches      11598    11597       -1     
============================================
+ Hits          18746    18748       +2     
+ Misses        56956    56922      -34     
+ Partials       2134     2132       -2

Impacted Files	Coverage Δ	Complexity Δ
...a/games/strategy/triplea/ui/menubar/LobbyMenu.java	0% <0%> (ø)	0 <0> (ø)	⬇️
.../strategy/triplea/odds/calculator/DummyPlayer.java	51.64% <0%> (+2.19%)	15% <0%> (+2%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28a7ef8...ebe38d0. Read the comment docs.

[RoiEXLab]

Hmm looks like coverage is still somewhat flaky.
DummyPlayer shouldn't have been affected by this