Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: inline ip extractor #5338

Merged
merged 1 commit into from Oct 12, 2019
Merged

Refactor: inline ip extractor #5338

merged 1 commit into from Oct 12, 2019

Conversation

DanVanAtta
Copy link
Member

Usage is now very minimal, can simply inline the utility 'ip extractor'.
Request objects have both IP and hostname, some care needs to be taken
to get the right value.

Functional Changes

[] New map or map update
[] New Feature
[] Feature update or enhancement
[] Feature Removal
[x] Code Cleanup or refactor
[] Configuration Change
[] Bug fix:
[] Other:

Testing

[x] No manual testing done
[] Manually tested

Usage is now very minimal, can simply inline the utility 'ip extractor'.
Request objects have both IP and hostname, some care needs to be taken
to get the right value.
@codecov-io
Copy link

Codecov Report

Merging #5338 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5338      +/-   ##
============================================
- Coverage     24.18%   24.17%   -0.01%     
+ Complexity     6756     6754       -2     
============================================
  Files          1013     1012       -1     
  Lines         77228    77227       -1     
  Branches      11496    11496              
============================================
- Hits          18675    18673       -2     
- Misses        56420    56421       +1     
  Partials       2133     2133
Impacted Files Coverage Δ Complexity Δ
.../server/error/reporting/ErrorReportController.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../src/main/java/games/strategy/net/nio/Decoder.java 65.51% <0%> (-1.73%) 11% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e914a9d...6f41d39. Read the comment docs.

@RoiEXLab RoiEXLab merged commit 78af8d1 into triplea-game:master Oct 12, 2019
@DanVanAtta DanVanAtta deleted the inline-ip-extractor branch November 17, 2019 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants