Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: inline ip extractor #5338

Merged
merged 1 commit into from Oct 12, 2019
Merged

Refactor: inline ip extractor #5338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions http-server/src/main/java/org/triplea/server/error/reporting/ErrorReportController.java
View file
Open in desktop
Expand Up @@ -15,7 +15,6 @@
import org.triplea.http.client.error.report.ErrorReportRequest;
import org.triplea.http.client.error.report.ErrorReportResponse;
import org.triplea.server.http.HttpController;
import org.triplea.server.http.IpAddressExtractor;

/** Http controller that binds the error upload endpoint with the error report upload handler. */
@Builder
Expand All @@ -37,6 +36,6 @@ public ErrorReportResponse uploadErrorReport(
throw new IllegalArgumentException("Missing error report body and/or title");
}

return errorReportIngestion.apply(IpAddressExtractor.extractClientIp(request), errorReport);
return errorReportIngestion.apply(request.getRemoteAddr(), errorReport);
}
}
18 changes: 0 additions & 18 deletions http-server/src/main/java/org/triplea/server/http/IpAddressExtractor.java
View file
Open in desktop

This file was deleted.

26 changes: 0 additions & 26 deletions http-server/src/test/java/org/triplea/server/http/IpAddressExtractorTest.java
View file
Open in desktop

This file was deleted.