Add missing null check to duplicated code #6801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'startTerritory' can be null. On line 392 there is a null check for 'startTerritory' (copy/pasted code), but we do not have the same on line 339 where we can get a NPE. Addresses NPE reported in: #6789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'startTerritory' can be null. On line 392 there
is a null check for 'startTerritory' (copy/pasted
code), but we do not have the same on line 339 where
we can get a NPE.
Addresses NPE reported in:
#6789
Functional Changes
[] New map or map update
[] New Feature
[] Feature update or enhancement
[] Feature Removal
[] Code Cleanup or refactor
[] Configuration Change
[x] Problem fix
[] Other:
Testing
Screens Shots
Additional Notes to Reviewer
Release Note
FIX|Fix NPE possible when AI is evaluating naval bombardment