Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce find_unlinked_contexts_in_context() helper #378

Merged
merged 2 commits into from
Oct 17, 2021

Conversation

Enselic
Copy link
Collaborator

@Enselic Enselic commented Oct 15, 2021

Glad to hear you liked my PoC for lazy-loading syntaxes! No worries about having a busy life :)

Here comes another PR. This one is pretty simple. But it will make the upcoming work and diff for #374 easier to do and read.

The code can be further simplified and refactored, but spare time is limited, and at this point I'd prefer to prioritize getting lazy-loading production ready.

First commit splits out a helper function (ignore white space when diffing to get a nice diff), and the second commit runs cargo fmt on the new helper function.

@Enselic
Copy link
Collaborator Author

Enselic commented Oct 15, 2021

I would like to give an overview of the journey ahead of us. The plan is to split up the prototype quality code in the PoC into 6 incremental steps. One PR per step, with the code turned into production quality code. The steps are:

And then, we're done ✅

@trishume trishume merged commit 8869491 into trishume:master Oct 17, 2021
@Enselic Enselic deleted the find_unlinked_contexts_in_context branch October 17, 2021 15:27
@Enselic Enselic mentioned this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants