-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move contexts
from SyntaxSet
into individual SyntaxReference
s
#382
Move contexts
from SyntaxSet
into individual SyntaxReference
s
#382
Conversation
This is in preparation of lazy-loading syntaxes on-demand.
The performance impact of this change is ~5% slower deserialization of before:
after:
|
As you can see, all syntect regression tests pass. So risk of behavioral regressions from this PR is low. I would actually go as far as to say "very low". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one thing which isn't a big deal.
Also I've added you as a collaborator to the repo to recognize you for your valuable contributions. Your PRs have consistently been high-quality, well-explained and well-tested. I also added you to the major contributors listed in the Readme (540555e). Thanks so much, sorry I've been so lazy about reviewing! What does this mean:
|
It is better to not compile than to crash later. And very few if any clients are likely to actually use this API. See trishume#382 (comment)
Thank you! I really appreciate that. On many levels. Don't worry too much about it sometimes taking some days before you get around to doing reviews. It really isn't that bad. I am grateful for that you still are nurturing this important and great project. A commit to fix your only comment has been pushed. |
It is better to not compile than to crash later. And very few if any clients are likely to actually use this API. See trishume#382 (comment)
@trishume Hi! Just wanted to let you know we are closing in on this being in review for a month. In light of #382 (comment) I will go ahead and merge it after a month has passed. Let me know if you want more time, that would be absolutely no problem at all :) And of course feel to ask me about anything related to this (or any other) PR! |
Thanks for the ping and sorry for the delay. It's been a busy time in my life including some traveling recently. I may have time to do some review Sunday but if I don't then I trust you to do a good job and am happy with you just merging it. |
This is in preparation of lazy-loading syntaxes on-demand. I think this is the most complicated change of the bunch.
Overview of the syntax lazy-loading work:
contexts
inSyntaxReference
tocontext_ids
#379contexts
fromSyntaxSet
into individualSyntaxReference
s #382SyntaxSet
when serializing it