Bump MSRV to 1.51 to fix build with latest plist release #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent release of plist bumped MSRV to 1.51 (see ebarnard/rust-plist#72 and discussions theirin), so we need to do that as well to fix this build error in CI: ``` error: failed to parse manifest at `/home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/time-0.3.5/Cargo.toml` Caused by: feature `resolver` is required this Cargo does not support nightly features, but if you switch to nightly channel you can add `cargo-features = ["resolver"]` to enable this feature ```
This was referenced Nov 22, 2021
Closed
|
I have confirmed that syntect still fails to build with Rust 1.50. Rust 1.51 is needed. I'll go ahead and merge this now since:
Another benefit of merging this is that I can make my other open PRs pass all CI checks. (I plan on doing a hard rebase on top of master now for all my other open PRs now that this PR is merged.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent release of plist bumped MSRV to 1.51 (see
ebarnard/rust-plist#72 and discussions therein). One easy way for us to deal with that is to also bump our MSRV to 1.51. I can't think of why this would be a big problem, so here is a PR that does that. It fixes this build error in MSRV CI that we currently get on the master branch (https://github.com/trishume/syntect/runs/4282657925?check_suite_focus=true):
Note that the build error is in time-rs, but it is plist that pulls in that dependency.