-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce owning IODescriptor #16
Conversation
Signed-off-by: szalpal <mszolucha@nvidia.com>
Signed-off-by: szalpal <mszolucha@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the CI testing updated to cover this failure case?
@deadeyegoodwin , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the new test running in CI? Don't you also need to make some change here: https://github.com/triton-inference-server/server/tree/master/qa/L0_backend_dali
Signed-off-by: szalpal <mszolucha@nvidia.com>
Signed-off-by: szalpal <mszolucha@nvidia.com>
Signed-off-by: szalpal <mszolucha@nvidia.com>
Signed-off-by: szalpal <mszolucha@nvidia.com>
Yes, I do need. I was going to do it after making this PR "Ready for review" :) |
Signed-off-by: szalpal <mszolucha@nvidia.com>
docs/examples/multi_input/README.md
Outdated
@@ -0,0 +1,18 @@ | |||
# Multi input model for DALI Backend | |||
|
|||
This is a multi input model, for DALI preprocessing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a multi input model, for DALI preprocessing. | |
This is a multi input model for DALI preprocessing. |
Signed-off-by: szalpal <mszolucha@nvidia.com>
This PR introduces changes to fix #14 : correcting TritonBackend API usage and introducing owning
IODescriptor
The solution is to add an owning
IODescriptor
. The data buffer obtained from Triton API comes in chunks and they need to be stitched together before passing the input into DALI. Therefore we do need an owning data structure. In future, DALI API might change so it would allow skipping this one extra copy.