Introduce owning IODescriptor #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: szalpal <mszolucha@nvidia.com>
Signed-off-by: szalpal <mszolucha@nvidia.com>
|
@deadeyegoodwin , |
There was a problem hiding this comment.
Is the new test running in CI? Don't you also need to make some change here: https://github.com/triton-inference-server/server/tree/master/qa/L0_backend_dali
Signed-off-by: szalpal <mszolucha@nvidia.com>
Signed-off-by: szalpal <mszolucha@nvidia.com>
Signed-off-by: szalpal <mszolucha@nvidia.com>
Signed-off-by: szalpal <mszolucha@nvidia.com>
Yes, I do need. I was going to do it after making this PR "Ready for review" :) |
szalpal
changed the title
szalpal
changed the title
Signed-off-by: szalpal <mszolucha@nvidia.com>
banasraf
reviewed
Jan 25, 2021
docs/examples/multi_input/README.md
Outdated
| @@ -0,0 +1,18 @@ | |||
| # Multi input model for DALI Backend | |||
|
|
|||
| This is a multi input model, for DALI preprocessing. | |||
There was a problem hiding this comment.
Suggested change
| This is a multi input model, for DALI preprocessing. | |
| This is a multi input model for DALI preprocessing. |
banasraf
previously approved these changes
Jan 25, 2021
Signed-off-by: szalpal <mszolucha@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes to fix #14 : correcting TritonBackend API usage and introducing owning
IODescriptorThe solution is to add an owning
IODescriptor. The data buffer obtained from Triton API comes in chunks and they need to be stitched together before passing the input into DALI. Therefore we do need an owning data structure. In future, DALI API might change so it would allow skipping this one extra copy.