Fix the lifetime of InferPayload (#241) #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add mutex for InferPayload to make sure it's thread-safe during callback * Remove reset for the promise * Address comment * Remove destructor * Fix lifetime of infer payload * Make sure the mutex is unlocked before promise.set_value * Revert "Make sure the mutex is unlocked before promise.set_value" This reverts commit 2eb5c32. * fix leak * Serialize all the responses in decoupled BLS * use enable_shared_from_this * Add a warning about using "GetPtr" * Remove the callback from mutex lock --------- Co-authored-by: Iman Tabrizian <itabrizian@nvidia.com>
krishung5
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mutex for InferPayload to make sure it's thread-safe during callback
Remove reset for the promise
Address comment
Remove destructor
Fix lifetime of infer payload
Make sure the mutex is unlocked before promise.set_value
Revert "Make sure the mutex is unlocked before promise.set_value"
This reverts commit 2eb5c32.
fix leak
Serialize all the responses in decoupled BLS
use enable_shared_from_this
Add a warning about using "GetPtr"
Remove the callback from mutex lock