Remove Caffe2 backend and relevant tests #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderHam
force-pushed
the
hemantj-rm-caffe2
branch
from
9cb0e4c
to
62d8e88
Compare
CoderHam
requested review from
tanmayv25,
deadeyegoodwin and
GuanLuo
and removed request for
tanmayv25 and
deadeyegoodwin
deadeyegoodwin
suggested changes
Oct 15, 2020
|
@CoderHam Also change the description of the commit to explicitly say "Remove Caffe2 backend..." |
CoderHam
changed the title
CoderHam
force-pushed
the
hemantj-rm-caffe2
branch
from
62d8e88
to
9e05edc
Compare
CoderHam
changed the title
CoderHam
force-pushed
the
hemantj-rm-caffe2
branch
from
9e05edc
to
0dea553
Compare
CoderHam
changed the title
CoderHam
force-pushed
the
hemantj-rm-caffe2
branch
2 times, most recently
from
ac6a93f
to
7a65c99
Compare
CoderHam
commented
Oct 19, 2020
deadeyegoodwin
previously approved these changes
Oct 19, 2020
CoderHam
force-pushed
the
hemantj-rm-caffe2
branch
2 times, most recently
from
7b38b44
to
67b933d
Compare
deadeyegoodwin
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensembles that used caffe2 models use graphdef instead.
In server status and lifecycle use onnx instead of netdef.
TODO: Follow up changes to doc to replace Caffe2 models in fetch_models.sh and documentation.