Add explicit model control test for Azure storage #3002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadeyegoodwin
previously approved these changes
Jun 10, 2021
tanmayv25
previously approved these changes
Jun 11, 2021
CoderHam
force-pushed
the
hemantj-azure-explicit
branch
from
42135eb
to
78cca68
Compare
- for cases where errno is set to 0 but blob_property.valid() = false
| @@ -916,7 +916,7 @@ ASFileSystem::FileModificationTime(const std::string& path, int64_t* mtime_ns) | |||
| RETURN_IF_ERROR(ParsePath(path, &container, &object_path)); | |||
|
|
|||
| auto blobProperty = bc.get_blob_property(container, object_path); | |||
| if (!blobProperty.valid()) { | |||
| if (errno != 0) { | |||
There was a problem hiding this comment.
Very strange for a C++ API to use errno...
There was a problem hiding this comment.
That is what I thought as well. Additionally there are some cases where the valid is set to false even when errno is set to 0. While I was not able to reproduce such a case this is what the caused the error that the user was seeing in issue 2966
deadeyegoodwin
approved these changes
Jun 11, 2021
tanmayv25
approved these changes
Jun 11, 2021
CoderHam
added a commit
that referenced
this pull request
Jun 12, 2021
* Add explicit model control test for Azure storage * Update copyright * Fix incorrectly detected failure when getting blob property - for cases where errno is set to 0 but blob_property.valid() = false * Update copyright * Improve verbose error logging for azure storage FS
CoderHam
added a commit
that referenced
this pull request
Jun 14, 2021
* Add explicit model control test for Azure storage * Update copyright * Fix incorrectly detected failure when getting blob property - for cases where errno is set to 0 but blob_property.valid() = false * Update copyright * Improve verbose error logging for azure storage FS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix case errno is 0 but the blob_property.valid() returns false. It appears errno is the correct way to check for errors based on the azure sdk sample.