Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][Proton][AMD] Fix test_cmd and enable CI on AMD #4026

Merged
merged 7 commits into from
Jun 7, 2024
Merged

[CI][Proton][AMD] Fix test_cmd and enable CI on AMD #4026

merged 7 commits into from
Jun 7, 2024

Conversation

CRobeck
Copy link
Contributor

@CRobeck CRobeck commented May 28, 2024

No description provided.

antiagainst
antiagainst reviewed May 28, 2024
View reviewed changes
Copy link
Collaborator

@antiagainst antiagainst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you enable CI for this?

@CRobeck CRobeck changed the title Get proton test_cmd passing on AMD Get proton test_cmd passing on AMD and enable CI May 28, 2024
@CRobeck
Copy link
Contributor Author

CRobeck commented May 28, 2024

@antiagainst the proton tests appear to pass locally. Can you take a look and see if I missed something in the yml files?

@CRobeck CRobeck changed the title Get proton test_cmd passing on AMD and enable CI [CI][Proton][AMD]Get proton test_cmd passing on AMD and enable CI May 28, 2024
@Jokeren Jokeren marked this pull request as ready for review June 7, 2024 16:25
@Jokeren Jokeren requested a review from ptillet as a code owner June 7, 2024 16:25
@Jokeren
Copy link
Contributor

Jokeren commented Jun 7, 2024

@antiagainst Any comments?

@CRobeck
Copy link
Contributor Author

CRobeck commented Jun 7, 2024

Depended on:
#4090

@antiagainst antiagainst changed the title [CI][Proton][AMD]Get proton test_cmd passing on AMD and enable CI [CI][Proton][AMD] Fix test_cmd and enable CI on AMD Jun 7, 2024
@Jokeren Jokeren merged commit 1466ad9 into triton-lang:main Jun 7, 2024
6 checks passed
@jlebar jlebar mentioned this pull request Jun 25, 2024
Closed
@CRobeck CRobeck deleted the proton_test_cmd branch August 23, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiagainst antiagainst antiagainst approved these changes

@ptillet ptillet Awaiting requested review from ptillet ptillet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CRobeck @Jokeren @antiagainst