[BACKEND] Fix an issue with the pipeliner #4247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What does ICE mean? |
I mean internal compiler error. Sorry for the confusion. I should just say a issue :) |
htyu
changed the title
|
This looks reasonable to me. I wonder if we can further reduce the test case. |
|
Thanks for fixing the bug! +1 to the @manman-ren request of coming up with simpler lit reproducer. |
|
Test reduced. |
|
Thanks for reducing the test case. LGTM |
manman-ren
approved these changes
Jul 9, 2024
|
Can confirm this fixes pytorch/pytorch#129911 |
|
This also fixes pytorch/pytorch#129625 |
|
Are there any labels / tracking needed to get this cherry-picked into the release branch? |
drisspg
pushed a commit
to drisspg/triton
that referenced
this pull request
Aug 19, 2024
During pipelining operations that do not depend on or being dependent by anchor operations are considered remaining ops and will be scheduled into the last stage. These ops do not present in the existing stages but can be visited by other staged ops. Fixing an ICE when looking for clusters for them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During pipelining operations that do not depend on or being dependent by anchor operations are considered remaining ops and will be scheduled into the last stage. These ops do not present in the existing stages but can be visited by other staged ops. Fixing an ICE when looking for clusters for them.