Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR] Add verifier for tt.broadcast #4286

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

shazqadeer
Copy link
Contributor

@shazqadeer shazqadeer commented Jul 9, 2024

Summary: This PR adds a verifier for tt.broadcast primitive to provide early error detection for incorrect usage.

Test Plan: New test

Reviewers: @htyu

Subscribers:

Tasks:

Tags:

The core Triton is a small number of people, and we receive many PRs (thank
you!). To help us review your code more quickly, if you are a new
contributor (less than 3 PRs merged) we ask that you complete the following
tasks and include the filled-out checklist in your PR description.

Complete the following tasks before sending your PR, and replace [ ] with
[x] to indicate you have done them.

  • I am not making a trivial change, such as fixing a typo in a comment.

  • I have written a PR description following these
    rules.

  • I have run pre-commit run --from-ref origin/main --to-ref HEAD.

  • Select one of the following.

    • I have added tests.
      • /test for lit tests
      • /unittest for C++ tests
      • /python/test for end-to-end tests
    • This PR does not need a test because FILL THIS IN.
  • Select one of the following.

    • I have not added any lit tests.
    • The lit tests I have added follow these best practices,
      including the "tests should be minimal" section. (Usually running Python code
      and using the instructions it generates is not minimal.)

@shazqadeer shazqadeer requested a review from ptillet as a code owner July 9, 2024 01:01
lib/Dialect/Triton/IR/Ops.cpp Outdated Show resolved Hide resolved
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@htyu
Copy link
Collaborator

htyu commented Jul 9, 2024

LGTM, thanks for your first commit to Triton!

Can you please retitle the PR to be something like "[IR] Add verifier for tt.broadcast"? Thanks.

@shazqadeer shazqadeer changed the title First commit for broadcast verifier [IR] Add verifier for tt.broadcast Jul 9, 2024
@shazqadeer
Copy link
Contributor Author

shazqadeer commented Jul 9, 2024

@htyu : I don't have write access to be able to merge the PR.

@ThomasRaoux ThomasRaoux merged commit 7a78c04 into triton-lang:main Jul 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants