Feature to avoid filtering or sorting on columns that are not rendered #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns that are not rendered
…curity section, to enable using or not, of the excluded attributes, on filtering and sorting.
| { | ||
| if ($this->strictFilteringAndSorting && $resourceConfig->isAttributeExcluded($resourceConfig->getRealPath($path))) { | ||
| if ($this->jsonApiDebug) { | ||
| throw InvalidRequest::createWithMessage($key, 'invalid_path', sprintf('There is no path called %s', $path)); |
There was a problem hiding this comment.
@yulioaj290 You forgot the else part
|
@yulioaj290 Thanks for the PR |
|
@trivago-makbarof you're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some new features to avoid filtering or sorting on columns that are not rendered.
The "excluded_attributes" configuration property was used to identify the not rendered columns and a new configuration property have been created, "strict_filtering_and_sorting" under security section, to tell to the bundle to ignore or not the excluded attributes used into the filtering or sorting.
The documentation has been updated properly.