-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting started with trixi #1343
Getting started with trixi #1343
Conversation
Hi @ArseniyKholod! Thanks for getting started with this. At the moment, all your files live in an extra directory, however, we want the tutorial to be integrated in our general documentation infrastructure. Could you thus please move the Literate files (i.e., the "normal" .jl file to the This should set up for the tutorial to be build automatically when the documentation is built. Then it becomes much easier for me to evaluate the contents of the tutorial :-) |
Hi @sloede! |
Now should be no troubles with compilation of all tutorials including new one (0th) |
New structure + new usage example
This reverts commit e2da5c2.
cd99efc
to
e2da5c2
Compare
This reverts commit 05d3d1c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I left a couple comments :)
Yes, thanks, works for me now too 🤷♂️ |
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! once the last remaining conversation has been resolved satisfactorily, this can be merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very nice and thorough tutorial @ArseniyKholod ! I just left a few comments / suggestions on wording.
Head branch was pushed to by a user without write access
Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
After resolving the merge conflicts coming from #1829, this LGTM. Thanks @ArseniyKholod. |
@andrewwinters5000 If you believe that all your comments have been addressed satisfactorily, please feel free to merge this (you need to override auto-merge since the CI tests will never run, but the docs have been built sucessfully) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
First version of 0th tutorial. (not completed)