Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting started with trixi #1343

Merged

Conversation

ArseniyKholod
Copy link
Contributor

First version of 0th tutorial. (not completed)

@sloede
Copy link
Member

sloede commented Jan 29, 2023

Hi @ArseniyKholod! Thanks for getting started with this. At the moment, all your files live in an extra directory, however, we want the tutorial to be integrated in our general documentation infrastructure. Could you thus please move the Literate files (i.e., the "normal" .jl file to the docs/literate/src/files directory (where also the other tutorials exist), and then add the filename and title (for the navigation bar) to
https://github.com/ArseniyKholod/Trixi.jl/blob/cb61c3a4ed896e62750408ef5de1f97e47c85ceb/docs/make.jl#L50-L71
?

This should set up for the tutorial to be build automatically when the documentation is built. Then it becomes much easier for me to evaluate the contents of the tutorial :-)

@ArseniyKholod
Copy link
Contributor Author

Hi @sloede!
I moved file to docs/literate/src/files and added named changes to make.jl.
But I'm not sure, that it is possible to update https://trixi-framework.github.io/Trixi.jl/stable/ from my forked Trixi copy.

@sloede sloede changed the title Getting started with trixi [WIP] Getting started with trixi Feb 7, 2023
@ArseniyKholod
Copy link
Contributor Author

Now should be no troubles with compilation of all tutorials including new one (0th)

Copy link
Contributor

@DanielDoehring DanielDoehring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left a couple comments :)

@sloede
Copy link
Member

sloede commented Feb 5, 2024

Issue with empty plot is not clear to me... Now all my devices show all pictures from tutorial, I hope it's okey now.

Yes, thanks, works for me now too 🤷‍♂️

sloede and others added 2 commits February 5, 2024 06:30
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
sloede
sloede previously approved these changes Feb 5, 2024
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! once the last remaining conversation has been resolved satisfactorily, this can be merged

@sloede sloede enabled auto-merge (squash) February 5, 2024 05:34
Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very nice and thorough tutorial @ArseniyKholod ! I just left a few comments / suggestions on wording.

auto-merge was automatically disabled February 5, 2024 08:10

Head branch was pushed to by a user without write access

Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
ArseniyKholod and others added 4 commits February 5, 2024 10:10
Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
sloede
sloede previously approved these changes Feb 5, 2024
DanielDoehring
DanielDoehring previously approved these changes Feb 5, 2024
@sloede sloede dismissed stale reviews from DanielDoehring and themself via fe88db4 February 5, 2024 16:07
@JoshuaLampert
Copy link
Member

After resolving the merge conflicts coming from #1829, this LGTM. Thanks @ArseniyKholod.

@sloede
Copy link
Member

sloede commented Feb 5, 2024

@andrewwinters5000 If you believe that all your comments have been addressed satisfactorily, please feel free to merge this (you need to override auto-merge since the CI tests will never run, but the docs have been built sucessfully)

Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewwinters5000 andrewwinters5000 merged commit 5fec7f4 into trixi-framework:main Feb 6, 2024
6 checks passed
@ArseniyKholod ArseniyKholod deleted the Getting_started_with_Trixi branch February 6, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants