Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: simplify channel handling #120

Merged
merged 10 commits into from
Sep 26, 2022

Conversation

benoit-pierre
Copy link
Contributor

  • as per the discussion in #117, remove the "Channel" panel, remove the user list window support for manually adding a channel, and update the search keywords to check for a channel ID.
  • add support for editing a channel name to the user list window.
  • factorize the code to support bringing the results context menu with the menu key to do the same with the user list, and fix a possible issue when Gtk animations are enabled.

Rational:

- listing a channel playlists / uploads by username is severely limited:
  it only works when there's no space in the username, and only for
  Youtube (and not Invidious contrary to what the API's documentation
  says).

- it's easier to just do a standard channel search, and use the right
  context menu, as it handle all cases: searching by username (including
  with spaces), searching for a channel by title, as well as listing a
  channel uploads when using a channel ID / URL.
Fix icon for "Remove" entry.
When trigged with the `menu` key and Gtk animations are enabled,
the menu would sometime be displayed outside of the bound of the
treeview visible area.
As a shortcut to bring up the popup menu.
Drop support for manually adding a new channel (see e058ed0 for rational).
@trizen trizen merged commit 69cf39d into trizen:main Sep 26, 2022
@benoit-pierre benoit-pierre deleted the pr/simplify_gui_channel_handling branch September 26, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants