Skip to content

Commit

Permalink
Revert "Revert issues to API v2 for patch release"
Browse files Browse the repository at this point in the history
This reverts commit 87889d9.
  • Loading branch information
sferik committed May 5, 2011
1 parent 6f254d5 commit 1023368
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 19 deletions.
24 changes: 18 additions & 6 deletions lib/octokit/client/issues.rb
Expand Up @@ -6,15 +6,27 @@ def search_issues(repo, search_term, state='open', options={})
get("api/v2/json/issues/search/#{Repository.new(repo)}/#{state}/#{search_term}", options)['issues']
end

def list_issues(repo, state='open', options={})
get("api/v2/json/issues/list/#{Repository.new(repo)}/#{state}", options)['issues']
# List issues for a repository
#
# @param repository [String, Repository, Hash] A GitHub repository.
# @param options [Hash] A customizable set of options.
# @option options [Integer] :milestone Milestone number.
# @option options [String] :state (open) State: <tt>open</tt> or <tt>closed</tt>.
# @option options [String] :assignee User login.
# @option options [String] :mentioned User login.
# @option options [String] :labels List of comma separated Label names. Example: <tt>bug,ui,@high</tt>.
# @option options [String] :sort (created) Sort: <tt>created</tt>, <tt>updated</tt>, or <tt>comments</tt>.
# @option options [String] :direction (desc) Direction: <tt>asc</tt> or <tt>desc</tt>.
# @option options [Integer] :page (1) Page number.
# @return [Array] A list of issues for a repository.
# @see http://developer.github.com/v3/issues/#list-issues-for-this-repository
# @example List issues for a repository
# Octokit.list_isses("sferik/rails_admin")
def list_issues(repository, options={})
get("/repos/#{Repository.new(repository)}/issues", options, 3)
end
alias :issues :list_issues

def issues_labeled(repo, label, options={})
get("api/v2/json/issues/list/#{Repository.new(repo)}/label/#{label}", options)['issues']
end

def create_issue(repo, title, body, options={})
post("api/v2/json/issues/open/#{Repository.new(repo)}", options.merge({:title => title, :body => body}))['issue']
end
Expand Down
16 changes: 3 additions & 13 deletions spec/octokit/client/issues_spec.rb
Expand Up @@ -21,24 +21,14 @@
describe ".list_issues" do

it "should return issues" do

stub_get("https://github.com/api/v2/json/issues/list/sferik/rails_admin/open").
to_return(:body => fixture("v2/issues.json"))
stub_get("https://api.github.com/repos/sferik/rails_admin/issues").
to_return(:body => fixture("v3/issues.json"))
issues = @client.issues("sferik/rails_admin")
issues.first.number.should == 105
issues.first.number.should == 388
end

end

describe ".issues_labeled" do
it "should return issues with a particular label" do
stub_get("issues/list/sferik/rails_admin/label/bug").
to_return(:body => fixture("v2/issues.json"))
issues = @client.issues_labeled("sferik/rails_admin", "bug")
issues.first.number.should == 105
end
end

describe ".create_issue" do

it "should create an issue" do
Expand Down

0 comments on commit 1023368

Please sign in to comment.