Skip to content

Commit

Permalink
rgw/s3: dump Message field in Error response even if empty
Browse files Browse the repository at this point in the history
some clients like veeam fail to decode the response if Message is missing

Fixes: https://tracker.ceph.com/issues/59433

Signed-off-by: Casey Bodley <cbodley@redhat.com>
  • Loading branch information
cbodley committed Apr 12, 2023
1 parent 9bea055 commit 6de9e37
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/rgw/rgw_common.cc
Original file line number Diff line number Diff line change
Expand Up @@ -368,8 +368,7 @@ void dump(req_state* s)
s->formatter->open_object_section("Error");
if (!s->err.err_code.empty())
s->formatter->dump_string("Code", s->err.err_code);
if (!s->err.message.empty())
s->formatter->dump_string("Message", s->err.message);
s->formatter->dump_string("Message", s->err.message);
if (!s->bucket_name.empty()) // TODO: connect to expose_bucket
s->formatter->dump_string("BucketName", s->bucket_name);
if (!s->trans_id.empty()) // TODO: connect to expose_bucket or another toggle
Expand Down

0 comments on commit 6de9e37

Please sign in to comment.