Skip to content

Commit

Permalink
Fix nasty parallel build problem reported by Gentoo and Westermo
Browse files Browse the repository at this point in the history
Independently of each other both the Gentoo project and Westermo found
an issue with massively parallel builds on monster-core-machines.  At
Westermo there are 40 core Xeon monsters that stumble when building
sysklogd.

The Gentoo bug report is here:

    https://bugs.gentoo.org/701894

The problem stems from strlcat.c and strlcpy.c being used for both
the libcompat convenience library built for libsyslog and als for
syslogd when the system does not have either of the APIs in libc,
i.e. most Linux systems with GLIBC or musl libc.

I can either rewrite the Makefile.am files to handle dependencies
better, or we just disable parallel build like this patch. There's
too few source files to gain anything from parallel build anyway.

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
  • Loading branch information
troglobit committed Dec 6, 2019
1 parent 3f94ae2 commit 9cf1f97
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,6 @@ release: distcheck
# Workaround for systemd unit file duing distcheck
DISTCHECK_CONFIGURE_FLAGS = --with-systemd=$$dc_install_base/$(systemd) --with-klogd

# Disable parallel build in top Makefile, we might otherwise get a very
# bizarre build problem with strlcpy.o in libcompat and for syslogd.
.NOTPARALLEL:

3 comments on commit 9cf1f97

@robertlinux
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I've sent a pull request to fix the issues, and restored the parallel build:

#12

@robertlinux
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the patch caused problems when make check, so I closed it.

@troglobit
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertlinux Yeah, this is a tough nut to crack without severely affecting readability/maintainability or other major surgery. I spent two whole days with ideas much like yours ... I may give it another go myself, later on since more features/files are coming, but right now I don't think it's worth the effort.

Please sign in to comment.