Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor proposals #48

Merged
merged 4 commits into from
Feb 9, 2024
Merged

Refactor proposals #48

merged 4 commits into from
Feb 9, 2024

Conversation

caindy
Copy link
Contributor

@caindy caindy commented Feb 8, 2024

following through on #46 (comment)

@caindy caindy self-assigned this Feb 8, 2024
Base automatically changed from 44-self-describing to 1.0.0-wip February 8, 2024 18:01
* eliminates distinct media type for a per-resource forecast--that's just a special case of a multiple-resource proposal
* accordingly, change POST to PATCH for realtime proposals
* renames `forecast-header` for proposals to `proposal-header` and adds it to realtime proposal, snapshots should have `snapshot-header`
@caindy caindy marked this pull request as ready for review February 8, 2024 18:12
Copy link
Contributor

@getorymckeag getorymckeag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this cleans things up.

@caindy caindy merged commit 2d24582 into 1.0.0-wip Feb 9, 2024
3 checks passed
@caindy caindy deleted the refactor-proposals branch February 9, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants