fix buffer overflow

git-svn-id: http://code.sixapart.com/svn/memcached/trunk@216 b0b603af-a30f-0410-a34e-baf09ae79d0b
trondn · Jul 22, 2004 · 8f5960e · 8f5960e
1 parent f227fae
commit 8f5960e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/ChangeLog b/ChangeLog
@@ -1,3 +1,8 @@
+2004-07-22
+	* fix buffer overflow in items.c with 250 byte keys along with
+	  other info on the same line going into a 256 byte char[].
+	  thanks to Andrei Nigmatulin <anight@monamour.ru>
+
 2004-06-15
 	* immediate deletes weren't being unlinked a few seconds,
 	  preventing "add" commands to the same key in that time period.

diff --git a/items.c b/items.c
@@ -214,7 +214,7 @@ char *item_cachedump(unsigned int slabs_clsid, unsigned int limit, unsigned int
     item *it;
     int len;
     int shown = 0;
-    char temp[256];
+    char temp[512];
 
     if (slabs_clsid > LARGEST_ID) return 0;
     it = heads[slabs_clsid];