Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGPL violation/Missing references to ethereumj project #25

Closed
freddy36 opened this issue Dec 31, 2017 · 85 comments
Closed

LGPL violation/Missing references to ethereumj project #25

freddy36 opened this issue Dec 31, 2017 · 85 comments

Comments

@freddy36
Copy link

freddy36 commented Dec 31, 2017

It's very obvious that java-tron is based on the ethereumj project.
E.g. compare these two files (Just a random example out of many):
https://github.com/tronprotocol/java-tron/blob/develop/src/main/java/org/tron/datasource/leveldb/LevelDbDataSource.java
https://github.com/ethereum/ethereumj/blob/develop/ethereumj-core/src/main/java/org/ethereum/datasource/leveldb/LevelDbDataSource.java

AFAIK this is violation of the LGPL (ethereumj) license because you didn't mention that java-tron has been derived from the ethereumj project.

You might want to get your licensing right. Copying someones work without giving them proper credits is at leased considered very bad practice in the open source community (ignoring any legal aspects of this because I'm not a lawyer).

@tronfoundation
Copy link
Contributor

We referred some codes of ETH due to the festinate time, we apologize for it and will correct it immediately.

@tahitithebob
Copy link

tahitithebob commented Jan 11, 2018

And you just moved the file and changed some properties...

the diff:

d4ad9c6#diff-acbc52c7b79e9618773211a957bb07fe

the new file:

https://github.com/tronprotocol/java-tron/blob/8e64485be80755de4f81ba472152777eb21f1131/src/main/java/org/tron/storage/leveldb/LevelDbDataSourceImpl.java

This is not cool!

@pornin
Copy link

pornin commented Jan 11, 2018

Also, files from https://github.com/tronprotocol/java-tron/tree/develop/src/main/java/org/tron/crypto/cryptohash appear to be straightforward imports from sphlib ( http://www.saphir2.com/sphlib/ ), with just the license removed and replaced with their own. Given that the sphlib license is very permissive and would see no problem with the import, provided that "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software" (exact wording of the license text), I'd say that this license surgery is quite inelegant. This is not the behaviour of worthy developers.

@ghost
Copy link

ghost commented Jan 12, 2018

When you get mauled by a bear, you know you've messed up badly.

@tronfoundation Congratulations on losing your overall credibility and general public image. By bluntly stealing code and claiming it to be yours, you've done more that ignoring international copyright laws and violating every single license involved. Way to go… has been a long time since I saw such an innovative way to kill a project's public image beyond the point of recovery.

@AngelQuirogaM
Copy link

I have been reading this thread in my email. Just take it easy for all please :)

For all not so constructive comments:

  • let the project developers breath a little bit please, and check it in the next release not at every commit.

For the developers:

  • all the comunity is watching you, please kill all legal doubts about this in the next release.

Have a good day

@tronfoundation
Copy link
Contributor

tronfoundation commented Jan 14, 2018

OFFICIAL STATEMENT

The design of TRON is based on it's own system and the realization of codes, some codes of Ethreum were used as reference, we didn't note related license, from now on we will note the copyright ownership and promise this won't happen again. Thank you for your support.

@larryluckland
Copy link

So all these Senior Alibaba engineers are just copying and pasting code? So much for Justin Sun and his "very strong developer team from great companies."

@pbuhrmann
Copy link

@larryluckland ever coded? copy paste is THE most powerful tool for any developer, thing is to know what to do with it afterwards. 95% of crypto is copy pasted code, however they should have left licenses untouched.

@ALawliet
Copy link

in on this because i wanna be a part of history. cheers everyone.

@tronprotocol tronprotocol deleted a comment from UseCoin Jan 15, 2018
@ac-opensource
Copy link

ac-opensource commented Jan 15, 2018

People are complaining about this like this is released already. It's not even "released" yet so no actual violation was committed.

Edit: Talking about the FUD. Reporting these mishaps are actually good. We can only do better from here.

@nanilab
Copy link

nanilab commented Jan 15, 2018

Not the first time TRON Protocol does this...

@KyleHunter
Copy link

@ac-opensource
Yes, but they have made significant monetary gains because of this premise.

@ghost
Copy link

ghost commented Jan 15, 2018

isn't tron a blockchain based in China?

@rdvo
Copy link

rdvo commented Jan 15, 2018

why is this a surprise.. this is how the Chinese do business. lol DUMP TRON

@kalittl
Copy link

kalittl commented Jan 15, 2018 via email

@lxwagn
Copy link

lxwagn commented Jan 15, 2018

This issue has been fixed as of commit 2754bcb51c4d51191e2b2c89346b76eff29e0ed3.

Please close the issue.

@rdvo
Copy link

rdvo commented Jan 15, 2018

amateur hour.. bulgarian coders copy pasting and removing licensing lol

@rmittapalliz
Copy link

Okay everyone just relax. copy paste not bad. But be open about it and give credit to ETH. @tronfoundation There is nothing wrong that your devlopers copy paste the code . if it helps tron to move forward by copy paste its definitely not a bad idea since it saves time. just dont forget to give credit.

i think people needs to stay away from development team and relax.

Copy pasting whitepaper is not cool tho.

@ptkenny
Copy link

ptkenny commented Jan 15, 2018

What's the point of free software if developers won't follow the licenses anyway?

@oferze
Copy link

oferze commented Jan 15, 2018

A crucial mistake in your official statement:

its, not it's.

@bonesoul
Copy link

Copy & paste the whitepaper, then copy & paste the sources. That's what we call TRON.

@YuurinBee
Copy link

Not to mention in your "official statement", you cannot even spell Ethereum correctly. You copy and pasted code, there's no reason you can't copy and paste the name, too... smh

@georgemickael-b
Copy link

For those who are whining about this issue. All these issues are common in development. If you say it's not, you haven't worked on serious projects with so much pressure to deliver. The thing hasn't even been released, its not even a violation now.

You are not going to perfect on day 1. This is professional network, don't undervalue yourself by making fake profiles and/or posting inappropriate comments.

@rmittapalliz
Copy link

rmittapalliz commented Jan 15, 2018 via email

@opuxilem-4055
Copy link

Protip: buy more when the price crashes super low!

@rome138
Copy link

rome138 commented Jan 15, 2018

Maybe it is commented out lol

@pyskell
Copy link

pyskell commented Jan 15, 2018

GPL covers whenever code is distributed. Even if not "released" it was still distributed on GitHub.

Additionally the first thing the copyright holder does is ask for proper licensing and attribution.

The disturbing/garbage part is that removing those copyright notices and find/replace ethereum -> tron DOESN'T happen by accident. This is the second incident after the whitepaper. A third will be a really serious pattern.

@myrual
Copy link

myrual commented Jan 15, 2018

in on this because i wanna be a part of history. cheers everyone.

@Mardoxx
Copy link

Mardoxx commented Jan 15, 2018

Has anyone called the cyberpolice?

@ruchernchong
Copy link
Contributor

@philiparthurmoore the best reply of the whole thread.

@zealthio
Copy link

@philiparthurmoore I second that. Leave it on twitter or Reddit BITCHES! They said sorry, wont happen again. Let them get on with the job.

@bulrush15
Copy link

bulrush15 commented Jan 15, 2018

Developer here. @georgemickael-b wholesale copying of licensed software, even open source software, without abiding by the license is not common where I'm from in the US. Maybe in India or China yes, but not in the US. It's ok to copy a few lines of code provided in a help forum, but not whole libraries and remove the license itself.

@githubbrunob
Copy link

@bulrush15 maybe they want to evolve the libraries, and therefore liability (e.g., in case of failure) should not go to the original authors.

@georgemickael-b
Copy link

@bulrush15 Sorry about you stereotypes. While you are thinking baselessly that following license is based on geography , my emphasis was , it is inevitable. If you had built/building an company and not working for a company , you would know this.
My point was to , get over the issue. Stop crying and focus on next milestone. You are not going to get everything right the first day.
This section is for reporting issues and getting to solve it. Not a platform for personal/racist
criticism. Be and act professional.

@fragamemnon
Copy link

fragamemnon commented Jan 15, 2018

Ther's nothing personal and nothing racist about his statement.

Even your example of starting up your own company is not applicable, since we are talking about a project worth billions, not a few thousand dollars.

@Namzhil
Copy link

Namzhil commented Jan 15, 2018

weak shit.

@lostick
Copy link

lostick commented Jan 15, 2018

awful thread, but what do you expect from blockchain devs who copy/paste code and remove licenses really...

@olibaron
Copy link

It says is enough that nobody of the supposed "40 devs" made the effort to reply to this thread......

@SparK-Cruz
Copy link

Intelectual property is bullshit, good evening.

@jtreal
Copy link

jtreal commented Jan 15, 2018

Removing the license took time so any defence of this act stating they lacked time is just baloney. Forget copyright etc.. The problem is they are taking credit for other people's work and trying to cover it up.

@joem789
Copy link

joem789 commented Jan 15, 2018

Too many people born into entitlement thinking they own their own ideas. To you copying is stealing. To others copying is reproducing something to learn from it. When an American copies a software program it becomes "reverse engineering" for some reason. I think all you lurkers should stay off here and let work get done peacefully. Try Googling China and Plagiarism and learn something about a culture that's not your own. Maybe then you will understand what is really happening here. Either you can be supportive or sit around and whine about things not suiting your ideas. Leave them alone. There are plenty of developers here who are being supportive and volunteering their time and efforts. Nobody needs you complainers here slowing down progress. The obstacles that are in place can be and will be overcome with a little more time. Give it a chance.

@ruchernchong
Copy link
Contributor

This thread has gone way off topic and off the actual purpose of an issue on Github. The collaborators or owner of this repo should just lock and limit the conversation to the contributors for quality discussion.

@ahivarn
Copy link

ahivarn commented Jan 15, 2018

So many major coins are forks of Bitcoin or similar currencies. That's open-source philosophy. Only issue here is the lack of attribution to proper sources.

The biggest issue with Tron is the excessive dumping happening as showing in Ether scan. Can @tronfoundation explain what's actually happening with people dumping hundreds of millions of coin at once

@Gomachi
Copy link

Gomachi commented Jan 15, 2018

@joem789 Your statements and "arguments" sound like a string of horrid jokes. I know you hold a sizeable amount of their shit tokens, but come on. If you're going to make an attempt at an argument, as least make it slightly reasonable and involving less straight up stupidity.

Too many people born into entitlement thinking they own their own ideas. To you copying is stealing. To others copying is reproducing something to learn from it. When an American copies a software program it becomes "reverse engineering" for some reason.

Apparently, you have no idea what 'copying' means in this context. First of all, we're not dealing with ideas here. Ethereum is an IMPLEMENTATION of an idea, not an idea. There's a difference between stealing an implementation (literally copy/paste source code) vs copying an idea. H.U.G.E .. DIFFERENCE. There's a reason why there are things called patents, intellectual property, and billions of dollars in IP lawsuits every year by companies.

If your "logic" was true, every company would be stealing from each other blatantly and indiscriminately, and nothing could be done.

The 'copying' you are trying to (and fail) to refer to is when a company sees a product that is gaining a lot of traction, and says "hey, we could create a product with pretty much the same features. Let's do it." Ahem, Instagram Stories features being derived from Snapchat.

It has absolutely nothing to do with "I'm just going to copy and paste code from some other codebase and claim it as my own. Herpa Derp."

Try Googling China and Plagiarism and learn something about a culture that's not your own. Maybe then you will understand what is really happening here.

Are ... you seriously trying to justify this by pulling some kind of nonsensical "culture" card?

"Let them be! It's their culture! Learn more about their plagiaristic culture and you'll then respect what the Tron team has done."

Whether or not plagiarism itself is rampant throughout China, you talk about it as if it's something that's good and should be revered. Wat?

Nobody needs you complainers here slowing down progress.

When that progress is copy/pasta code from other codebases and claiming it as your own, you better bet your butt people are going to complain.

The obstacles that are in place can be and will be overcome with a little more time. Give it a chance.

What? Do you stray onto a different topic? It sounds like you're now addressing people who are pissed about ... slow development time? I don't see how this has anything to do with anything that was stated prior.

@joem789
Copy link

joem789 commented Jan 15, 2018

I guarantee your grandmother copied a recipe from a book and called it her own. Her special touches made it her own. But still copied nevertheless. When 3M company glue patent ran out, many companies copied it to make innovative products better than 3M! That's innovation in the name of plagiarism! It's all in how you look at it. Furthermore. It amazes me at how many people cry plagiarism in an open source community. Sounds pretty hypocritical. I am an American. And the first to admit our society is one of a sense of entitlement where we get to own ideas. Which is worthy of a joke. Because you cannot own intelligence. I grew up copying everything everyone did to get good at adapting and overcoming challenges. If people had hovered around me during that time, they would have been complaining cause I stole their ideas. Can anyone prove that Alibaba wasn't plagiarized to become the product it is? Why not? After all, Asia seems to copy everything. And somehow, they still dominate the world with their products. Products that YOU are thankful for every day because of the cheap prices.

I personally see this TRON project as something more than coding and crypto dogs. I see it as a collaboration between East and West and a chance to tear down cultural carriers that exist. Finding a new common ground. But this isn't about Asia assimilating to American culture. It is about both sides re-evaluating their beliefs. There's a helluva lot that needs to change just on the American side.

@jtreal
Copy link

jtreal commented Jan 15, 2018

@joem789 professional developers see through that poor attempt at a strawman fallacy. This is just a slap on the wrist but it seems to be exposing awful ethics and a lot of red flags. Then again Alibaba is a copy of ebay/amazon lest we forget so who is really surprised by this behaviour.
I'd be more concerned by the lack of activity and real work done so far than defending this violation.

@kemargrant
Copy link

200

@ac-opensource
Copy link

@wongjustin99 Submitted a fix: #65

@twixr
Copy link

twixr commented Jan 16, 2018

@joem789
I guarantee your grandmother copied a recipe from a book and called it her own.

But she never publicly "released" it under her own name, does she?

@jameslouiz
Copy link

jameslouiz commented Jan 17, 2018

I think people are missing the point and saying its okay to copy code. The main point is they have lied about it and tried to cover it up which raises more questions about the legitimacy of the project and the capability of the team.

What other shady tactics are happening that we can't see?

Also, @joem789 you have absolutely no idea what you're talking about.

sasaxie pushed a commit that referenced this issue Apr 18, 2018
@ghost
Copy link

ghost commented Jun 14, 2018

Never expected this from TRON

@lastbattle
Copy link

WELCOME TO CHINA!!!!
JUST COPY. Who gives a shit about licenses?

@Abiraminfo
Copy link

Bidu a successful Chinese search engine company is a copy of Google.
QQ Chinese social networking company is a copy of Facebook.
Huawei is a successful Chinese copycat of Cisco .
Xiomi is a successful Chinese copycat of iPhone .
Wechat is a Chinese copycat of WhatsApp.
Alibaba itself is an extremely successful copycat of eBay .

So being a Chinese copycat could as well means success. China doesn't allow foregin companies taking strong root within it's borders. If China wants to allow a crypto currency to operate in China, it might as well be TRON ! Don't be surprised, it's a huge market on it's own and copyright doesn't matter there 😂

@bdm123
Copy link

bdm123 commented Jun 20, 2018

Copying and stealing code is different than copying a business model.

What a shit show this is going to be. Good luck on the grenade launch. LOL 😂

@ruchernchong
Copy link
Contributor

ruchernchong commented Jun 20, 2018

@tronfoundation @sasaxie I think this issue should be locked and limited to members and collaborators only.

@tronprotocol tronprotocol locked and limited conversation to collaborators Jun 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests