Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db): fix getHeadBlockId abnormal return problem #5403

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

xxo1shine
Copy link
Contributor

@xxo1shine xxo1shine commented Aug 8, 2023

What does this PR do?
Fix getHeadBlockId abnormal return problem, fix #5389.

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-commenter
Copy link

Codecov Report

Merging #5403 (5ce3ff0) into develop (10223cc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             develop    #5403   +/-   ##
==========================================
  Coverage      60.89%   60.90%           
+ Complexity      9231     9230    -1     
==========================================
  Files            839      839           
  Lines          50029    50027    -2     
  Branches        5574     5574           
==========================================
  Hits           30467    30467           
+ Misses         17176    17173    -3     
- Partials        2386     2387    +1     
Files Changed Coverage Δ
.../src/main/java/org/tron/core/ChainBaseManager.java 91.19% <100.00%> (-1.36%) ⬇️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@halibobo1205 halibobo1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@halibobo1205 halibobo1205 added this to the GreatVoyage-v4.7.3 milestone Aug 9, 2023
@halibobo1205
Copy link
Contributor

halibobo1205 commented Aug 9, 2023

fix #5389

@xxo1shine xxo1shine merged commit f33c169 into tronprotocol:develop Aug 11, 2023
7 checks passed
@xxo1shine xxo1shine deleted the fix_getHeadBlockId branch May 28, 2024 01:16
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getHeadBlockId abnormal return
4 participants