Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(net): fix bug of getting head block concurrently #5532

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

317787106
Copy link
Contributor

What does this PR do?

  • fix bug of getting head block concurrently in construct ChainInventoryMessage

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@317787106 317787106 linked an issue Oct 12, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Merging #5532 (e352152) into release_v4.7.3 (9842b3f) will increase coverage by 1.02%.
Report is 19 commits behind head on release_v4.7.3.
The diff coverage is 74.50%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@                 Coverage Diff                  @@
##             release_v4.7.3    #5532      +/-   ##
====================================================
+ Coverage             64.99%   66.02%   +1.02%     
- Complexity            10020    10152     +132     
====================================================
  Files                   894      894              
  Lines                 53816    53847      +31     
  Branches               5926     5929       +3     
====================================================
+ Hits                  34979    35552     +573     
+ Misses                16123    15516     -607     
- Partials               2714     2779      +65     
Files Coverage Δ
framework/src/main/java/org/tron/core/Wallet.java 58.45% <ø> (+9.72%) ⬆️
...ices/http/solidity/SolidityNodeHttpApiService.java 94.11% <100.00%> (+91.08%) ⬆️
...a/org/tron/tool/litefullnode/LiteFullNodeTool.java 75.55% <100.00%> (+0.07%) ⬆️
...e/net/messagehandler/SyncBlockChainMsgHandler.java 30.15% <0.00%> (-1.59%) ⬇️
.../main/java/org/tron/core/db2/common/TxCacheDB.java 84.81% <81.39%> (-0.84%) ⬇️

... and 48 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@317787106 317787106 merged commit e987efb into tronprotocol:release_v4.7.3 Oct 12, 2023
5 checks passed
@halibobo1205 halibobo1205 added this to the GreatVoyage-v4.7.3 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimze logic of construct ChainInventoryMessage
5 participants