feat(rpc): gRPC reflection service support #5583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomatoishealthy What does this service do? |
lurais
reviewed
Nov 15, 2023
| @@ -124,6 +125,10 @@ public void start() { | |||
| // add lite fullnode query interceptor | |||
| serverBuilder.intercept(liteFnQueryGrpcInterceptor); | |||
|
|
|||
| if (parameter.isRpcReflectionServiceEnable()) { | |||
There was a problem hiding this comment.
Should the parameter rpcReflectionServiceEnable control all the RpcApiServices? It seems to be not flexible to use only one parameter to control all .
There was a problem hiding this comment.
gRPC reflection is a tiny feature for a better UX, providing individual parameters for each service is a bit redundant
As the issue claimed, provide a better UX for gRPC APIs |
jwrct
approved these changes
Nov 17, 2023
lurais
reviewed
Dec 8, 2023
| @@ -284,6 +284,9 @@ node { | |||
| # "getaccount", | |||
| # "getnowblock2" | |||
| # ] | |||
|
|
|||
| # The switch of the reflection service, effective for all gRPC services | |||
There was a problem hiding this comment.
This config path "reflectionService" not match with the Args.
There was a problem hiding this comment.
What do you mean by "not match with the Args", more details?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5391