feat(db): optimize calculation services for reward when the node starts #5654
Conversation
halibobo1205
requested review from
yanghang8612,
317787106,
tomatoishealthy,
xxo1shine and
jwrct
| @@ -465,6 +469,7 @@ public void init() { | |||
| revokingStore.disable(); | |||
| revokingStore.check(); | |||
| transactionCache.initCache(); | |||
| rewardViCalService.init(); | |||
There was a problem hiding this comment.
If rewardViCalService is initialized behind revokingStore.check(), is the latestBlockNumber check still necessary?
There was a problem hiding this comment.
scenes are synchronized from 0 and never restarted, check is still necessary.
| if (ret) { | ||
| // checkpoint is flushed to db, we can start rewardViCalService immediately | ||
| lastBlockNumber = Long.MAX_VALUE; | ||
| } |
There was a problem hiding this comment.
There is no need to define this variable ret.
The style needs to be consistent, lastBlockNumber -> this.lastBlockNumber
| if (ret) { | ||
| // checkpoint is flushed to db, we can start rewardViCalService immediately | ||
| lastBlockNumber = Long.MAX_VALUE; | ||
| } | ||
| es.scheduleWithFixedDelay(this::maybeRun, 0, 3, TimeUnit.SECONDS); |
There was a problem hiding this comment.
What is the significance of this code in the enableNewRewardAlgorithm function?
if (ret && lastBlockNumber == -1) {
lastBlockNumber = this.getLatestBlockHeaderNumber();
}
There was a problem hiding this comment.
For the block-catching case, record the block for which NewRewardAlgorithm is in effect, and wait for the block to be flushed before data computation to ensure data consistency.
There was a problem hiding this comment.
This function getLatestBlockHeaderNumber obtains the data of the underlying database, right?
We can start working on computational tasks immediately without waiting for a minimum of one block to synchronize if the new reward algorithm is already in effect when the node starts.