Include the route's verbs if they are constrained to certain verbs #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have two routes with the same path, but different verbs then you will get a duplicate key exception when attempting to add the second route. This change appends the route verb/http method if it is constrained to certain http methods. If they are not constrained it should allow anything through. I believe I have preserved backwards compatibility, and added new unit tests for the verb functionality.
I believe everything is ready to push the update to NuGet, but it was published under your account, so if you want to push the update that would be great! Otherwise I can look at publishing myself.