add `@typescript-eslint/no-floating-promises` #1671

john-schmitz · 2022-03-22T18:44:32Z

I am honestly not sure even if we should handle any errors comming from res.header() thats why I voided it

fixes #1577

KATT

Not at a computer but have a look to see if any of the ❌ CI steps are obvious

john-schmitz · 2022-03-22T20:11:48Z

Not at a computer but have a look to see if any of the x CI steps are obvious

The fix is non-releated to the PR, but I can help

vercel · 2022-03-22T20:16:10Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

next-prisma-starter – ./examples/next-prisma-starter

🔍 Inspect: https://vercel.com/trpc/next-prisma-starter/136eCDwwu9Y47E8rqj8Mp1rFsKLH
✅ Preview: https://next-prisma-starter-git-fix-1577-trpc.vercel.app

www – ./www

🔍 Inspect: https://vercel.com/trpc/www/GUkCa6ezDUt4CzTjiWxrXqDYPsHy
✅ Preview: https://www-git-fix-1577-trpc.vercel.app

skarab42

Looks good :)

KATT · 2022-03-22T21:26:29Z

.tool-versions

@@ -0,0 +1 @@
+nodejs 14.19.1


Do nvm automatically pick this up

If you're using asdf, you can have it read from .nvmrc anyway. nvm does not read from .tool-versions at all though. Unfortunately, the ideal solution would be to have both.

Let's use .nvmrc if that works for both 🤷

KATT · 2022-03-22T21:27:28Z

examples/next-prisma-starter/.eslintrc

@@ -7,6 +7,7 @@
    "plugin:prettier/recommended"
  ],
  "parserOptions": {
+    "project": "tsconfig.json",


This doesn't look related to this PR? We only need to change config at the root level of the project

Suggested change

"project": "tsconfig.json",

packages/server/src/adapters/fastify/fastifyRequestHandler.ts

packages/server/src/adapters/ws.ts

KATT · 2022-03-22T21:32:43Z

packages/server/src/subscription.ts

@@ -147,7 +147,7 @@ export function subscriptionPullFactory<TOutput>(opts: {
  }

  return new Subscription<TOutput>((emit) => {
-    _pull(emit);
+    _pull(emit).catch((err) => emit.error(getErrorFromUnknown(err)));


KATT · 2022-03-22T21:33:17Z

@all-contributors add @john-schmitz for code

allcontributors · 2022-03-22T21:33:25Z

@KATT

I've put up a pull request to add @john-schmitz! 🎉

KATT

The CI changes looks very much like they have to do with this PR. I tried re-running and it's fine on main

Co-authored-by: Alex Johansson <alexander@n1s.se>

KATT

Some last tweaks then 🚀

packages/server/src/adapters/fastify/fastifyRequestHandler.ts

john-schmitz · 2022-03-22T22:44:43Z

Sorry for the messed up configuration, did not realize that would break the examples.

But alas! It's fixed

KATT · 2022-03-22T23:31:01Z

@john-schmitz you have no GitHub sponsors setup, if you want to, set one up and I'll send you a thank you!

john-schmitz · 2022-03-22T23:56:40Z

@john-schmitz you have no GitHub sponsors setup, if you want to, set one up and I'll send you a thank you!

I just requested for it! And thank you very much for your project, I contribuited first and foremost because I admire it.

jlalmes · 2022-03-23T10:44:40Z

Thanks for this - was meaning to get around to it at some point! 🚀

github-actions · 2022-10-06T18:04:34Z

This pull request has been locked because it had no new activity for 30 days. If you think, this PR is still necessary, create a new one with the same branch. Thank you.

john-schmitz added 5 commits March 22, 2022 12:16

add rule no-floating-promises to eslint

1e88434

fix express non handled promisses

2a9ad0d

fix fastify non handled promisses

487f9ea

Fix unhandled promises in ws

bdbd823

Fix unhandled promises in subscription pull

7a38452

john-schmitz requested review from KATT and skarab42 March 22, 2022 18:44

KATT reviewed Mar 22, 2022

View reviewed changes

Add project setting to eslintrc to next-prisma-starter

5a495dc

vercel bot deployed to Preview – todomvc March 22, 2022 20:16 View deployment

vercel bot deployed to Preview – next-prisma-starter March 22, 2022 20:16 View deployment

vercel bot deployed to Preview – www March 22, 2022 20:16 View deployment

skarab42 approved these changes Mar 22, 2022

View reviewed changes

KATT reviewed Mar 22, 2022

View reviewed changes

allcontributors bot mentioned this pull request Mar 22, 2022

docs: add john-schmitz as a contributor for code #1672

Merged

KATT reviewed Mar 22, 2022

View reviewed changes

john-schmitz and others added 2 commits March 22, 2022 18:47

Remove .tool-versions

19d1f16

Update packages/server/src/adapters/ws.ts

1f2eddc

Co-authored-by: Alex Johansson <alexander@n1s.se>

vercel bot deployed to Preview – next-prisma-starter March 22, 2022 21:50 View deployment

vercel bot deployed to Preview – www March 22, 2022 21:50 View deployment

Merge branch 'fix/1577' of https://github.com/trpc/trpc into fix/1577

93a0dce

vercel bot deployed to Preview – todomvc March 22, 2022 21:51 View deployment

Add project property to .eslint in next-prisma-starter-websockets

5bce586

vercel bot deployed to Preview – todomvc March 22, 2022 22:01 View deployment

vercel bot deployed to Preview – www March 22, 2022 22:01 View deployment

vercel bot deployed to Preview – next-prisma-starter March 22, 2022 22:01 View deployment

KATT mentioned this pull request Mar 22, 2022

@typescript-eslint/no-floating-promises #1623

Closed

KATT requested changes Mar 22, 2022

View reviewed changes

packages/server/src/adapters/fastify/fastifyRequestHandler.ts Outdated Show resolved Hide resolved

packages/server/src/adapters/fastify/fastifyRequestHandler.ts Show resolved Hide resolved

Update packages/server/src/adapters/fastify/fastifyRequestHandler.ts

add692d

vercel bot deployed to Preview – next-prisma-starter March 22, 2022 22:45 View deployment

vercel bot deployed to Preview – todomvc March 22, 2022 22:45 View deployment

vercel bot deployed to Preview – www March 22, 2022 22:45 View deployment

KATT added 2 commits March 22, 2022 23:45

Update packages/server/src/adapters/fastify/fastifyRequestHandler.ts

405d5e5

Merge branch 'main' into fix/1577

551d37c

KATT added the ♻️ autoupdate label Mar 22, 2022

vercel bot deployed to Preview – www March 22, 2022 22:45 View deployment

KATT enabled auto-merge (squash) March 22, 2022 22:46

KATT approved these changes Mar 22, 2022

View reviewed changes

vercel bot deployed to Preview – todomvc March 22, 2022 22:46 View deployment

vercel bot deployed to Preview – next-prisma-starter March 22, 2022 22:47 View deployment

Merge branch 'main' into fix/1577

665f08a

vercel bot deployed to Preview – todomvc March 22, 2022 22:49 View deployment

vercel bot deployed to Preview – next-prisma-starter March 22, 2022 22:49 View deployment

vercel bot deployed to Preview – www March 22, 2022 22:49 View deployment

fix 🤷

29d89cc

vercel bot deployed to Preview – todomvc March 22, 2022 23:11 View deployment

vercel bot deployed to Preview – next-prisma-starter March 22, 2022 23:11 View deployment

vercel bot deployed to Preview – www March 22, 2022 23:11 View deployment

KATT merged commit cef6f2b into main Mar 22, 2022

KATT deleted the fix/1577 branch March 22, 2022 23:33

github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add `@typescript-eslint/no-floating-promises` #1671

add `@typescript-eslint/no-floating-promises` #1671

john-schmitz commented Mar 22, 2022

KATT left a comment

john-schmitz commented Mar 22, 2022

vercel bot commented Mar 22, 2022 •

edited

skarab42 left a comment

KATT Mar 22, 2022

sachinraja Mar 22, 2022

KATT Mar 22, 2022

KATT Mar 22, 2022

KATT Mar 22, 2022

KATT commented Mar 22, 2022

allcontributors bot commented Mar 22, 2022

KATT left a comment

KATT left a comment

john-schmitz commented Mar 22, 2022

KATT commented Mar 22, 2022

john-schmitz commented Mar 22, 2022

jlalmes commented Mar 23, 2022

github-actions bot commented Oct 6, 2022

add @typescript-eslint/no-floating-promises #1671

add @typescript-eslint/no-floating-promises #1671

Conversation

john-schmitz commented Mar 22, 2022

KATT left a comment

Choose a reason for hiding this comment

john-schmitz commented Mar 22, 2022

vercel bot commented Mar 22, 2022 • edited

next-prisma-starter – ./examples/next-prisma-starter

www – ./www

skarab42 left a comment

Choose a reason for hiding this comment

KATT Mar 22, 2022

Choose a reason for hiding this comment

sachinraja Mar 22, 2022

Choose a reason for hiding this comment

KATT Mar 22, 2022

Choose a reason for hiding this comment

KATT Mar 22, 2022

Choose a reason for hiding this comment

KATT Mar 22, 2022

Choose a reason for hiding this comment

KATT commented Mar 22, 2022

allcontributors bot commented Mar 22, 2022

KATT left a comment

Choose a reason for hiding this comment

KATT left a comment

Choose a reason for hiding this comment

john-schmitz commented Mar 22, 2022

KATT commented Mar 22, 2022

john-schmitz commented Mar 22, 2022

jlalmes commented Mar 23, 2022

github-actions bot commented Oct 6, 2022

add `@typescript-eslint/no-floating-promises` #1671

add `@typescript-eslint/no-floating-promises` #1671

vercel bot commented Mar 22, 2022 •

edited