Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: CI support node18 (#3093) #3141

Merged
merged 16 commits into from Nov 23, 2022
Merged

chore: CI support node18 (#3093) #3141

merged 16 commits into from Nov 23, 2022

Conversation

sun0day
Copy link
Contributor

@sun0day sun0day commented Nov 8, 2022

Closes #3093

🎯 Changes

What changes are made in this PR? Is it a feature or a bug fix?

✅ Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@vercel
Copy link

vercel bot commented Nov 8, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
next-prisma-starter ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Nov 23, 2022 at 10:36PM (UTC)
www ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Nov 23, 2022 at 10:36PM (UTC)

@sun0day
Copy link
Contributor Author

sun0day commented Nov 8, 2022 •
edited

Seems like wait-on doesn't work on node18 when host is set localhost.

See jeffbski/wait-on#109 and nodejs/node#40702

We could change localhost to 127.0.0.1 to bypass this problem.

node16 required CI needs to be changed to node18

image

KATT
KATT previously approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@KATT KATT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing. I will update the branch protection rules ASAP & merge this!

@KATT
Merge remote-tracking branch 'origin/next' into feat/node18
dca2efc 
# Conflicts:
#	.github/workflows/lint.yml
@KATT KATT enabled auto-merge (squash) November 23, 2022 22:46
@KATT KATT merged commit 039aa53 into main Nov 23, 2022
@KATT KATT deleted the feat/node18 branch November 23, 2022 22:46
KATT added a commit that referenced this pull request Nov 26, 2022
@KATT
chore: CI support node18 (#3093) (#3141)
1410086 
Co-authored-by: KATT <alexander@n1s.se>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KATT KATT KATT approved these changes

@trpc-bot trpc-bot Awaiting requested review from trpc-bot

@sachinraja sachinraja Awaiting requested review from sachinraja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: node 18
2 participants
@sun0day @KATT