hide never values in intellisense for jsonify #3264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KATT
approved these changes
Nov 26, 2022
There was a problem hiding this comment.
Can we add some tests here? https://github.com/trpc/trpc/blob/main/packages/tests/server/jsonify.test.ts
KATT
reviewed
Nov 26, 2022
Comment on lines
+62
to
+65
| Pick<T, FilterDefinedKeys<T>> & { | ||
| // Property _is_ a union with `defined`. Set as optional (via `?`) and remove `undefined` from the union | ||
| [k in keyof Omit<T, FilterDefinedKeys<T>>]?: Exclude<T[k], undefined>; | ||
| }; |
There was a problem hiding this comment.
This looks quite "heavy" but before looked heavy too... reminds me of our OmitNeverKeys that ended up being slow.
FWIW, I think it's fine to expose never keys.... maybe an even better thing would be some DX like this:
const output = {
bigint: 0n,
}
// ... then
serializedOutput.bigint
// ^? Error<"This type is not JSON-serializable">There was a problem hiding this comment.
yeah this is the same as before, I just refactored it a bit. This part doesn't change with the never keys. It just has to be done unless we somehow come up with something more optimized.
sachinraja
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of #3261