Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch(next): rm react-ssr-prepass dependency #5201

Merged
merged 4 commits into from
Dec 23, 2023
Merged

patch(next): rm react-ssr-prepass dependency #5201

merged 4 commits into from
Dec 23, 2023

Conversation

KATT
Copy link
Member

@KATT KATT commented Dec 22, 2023

Closes #3343
Closes #5133

🎯 Changes

Removes the need of react-ssr-prepass. Seems like it was never needed, since we don't support suspense in the prepassing anyway.

✅ Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@KATT KATT requested a review from luixo December 22, 2023 21:32
@KATT KATT requested a review from a team as a code owner December 22, 2023 21:32
@vercel Vercel
Copy link

vercel bot commented Dec 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-prisma-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2023 8:53am
og-image ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2023 8:53am
trpc-next-app-dir ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2023 8:53am
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2023 8:53am

This was referenced Dec 22, 2023
Merged
Closed
@xiaolongkipsi
Copy link

when can we expect release 11?

luixo
luixo approved these changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@luixo luixo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still weird we have to import react-dom async, but as long as it works - LGTM

@KATT
Copy link
Member Author

KATT commented Dec 23, 2023

Just use the canary tagged release

@KATT KATT enabled auto-merge (squash) December 23, 2023 08:51
@KATT KATT disabled auto-merge December 23, 2023 09:00
@KATT KATT merged commit 196c934 into main Dec 23, 2023
41 checks passed
@KATT KATT deleted the rm-prepass branch December 23, 2023 09:00
@github-actions GitHub Actions
Copy link

This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luixo luixo luixo approved these changes

Assignees
No one assigned
Labels
♻️ autoupdate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(external): an issue in dependency react-ssr-prepass
3 participants
@KATT @xiaolongkipsi @luixo