-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): websocket keep alive #5715
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
@buraktt is attempting to deploy a commit to the trpc Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Please use fake timers so the tests don't take over 3 seconds to run π
Thanks for the quick review. Changes implemented π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
FYI we'll have support for SSE soon too which will be nicer to use than WSS. you can peek in #5713
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually - one more thing - please add docs too! π Sorry I missed that was missing
@KATT docs updated. |
Just for curiosity, when is this useful? Heartbeat is built into the WebSocket standard already. |
@BeBoRE this is useful when you need to keep connection open by utilizing |
Ohh, so heartbeat isn't done automatically? I thought the |
This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you. |
Closes #2822
π― Changes
Heartbeat logic is implemented to keep connection alive.
β Checklist