V9 refactoring and cleanup #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). www – ./www🔍 Inspect: https://vercel.com/trpc/www/9ocnssrTJBNMfbpkMu2KUNoTuDs1 todomvc – ./examples/next-prisma-todomvc🔍 Inspect: https://vercel.com/trpc/todomvc/4AtubuWG1U2EufXWfFgy9zpEqGcL |
KATT
added
⏭ major bump needed
# Conflicts: # packages/server/test/index.test.tsx # packages/server/test/middleware.test.ts # www/docs/server/authorization.md
KATT
requested review from
cyrus-za and
simonedelmann
and removed request for
cyrus-za
anthonyshort
approved these changes
Aug 19, 2021
simonedelmann
approved these changes
Aug 20, 2021
# Conflicts: # packages/server/test/middleware.test.ts
cyrus-za
reviewed
Aug 20, 2021
| @@ -12,8 +12,7 @@ const JSONRPC2_TO_HTTP_CODE: Record< | |||
| > = { | |||
| PARSE_ERROR: 400, | |||
| BAD_REQUEST: 400, | |||
| METHOD_NOT_FOUND: 405, | |||
| PATH_NOT_FOUND: 404, | |||
| NOT_FOUND: 404, | |||
There was a problem hiding this comment.
Why no 405 METHOD_NOT_ALLOWED?
| @@ -270,7 +270,7 @@ describe('integration tests', () => { | |||
| trpc.router<Context>().query('whoami', { | |||
| async resolve({ ctx }) { | |||
| if (!ctx.user) { | |||
| throw trpc.httpError.unauthorized(); | |||
| throw new TRPCError({ code: 'UNAUTHORIZED' }); | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Think this PR along with #718 settles what I want to do with the next major update.
Keen to have any input on other fundamentals people / API surfaces or shapes that people think should change (including if you disagree with the changes here) - ping @cyrus-za / @anthonyshort / @peterp / @mmkal .
Summary of changes
TRPCErrors -METHOD_NOT_FOUNDremoved &PATH_NOT_FOUNDrenamed toNOT_FOUND(closes ReduceTRPCError-codes #733)httpErrors-helper?inputto be an array - now assuming aRecord<number, unknown>-style dict (changed with backwards compat in fix: batching with zod.optional()input #669)POSTcalls being{ input: x }(originally from flatten post requests'input#671)