Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve transpose handling #219

Merged
merged 2 commits into from
Nov 27, 2021
Merged

Improve transpose handling #219

merged 2 commits into from
Nov 27, 2021

Conversation

chriskrycho
Copy link
Collaborator

@chriskrycho chriskrycho commented Nov 27, 2021

  • Revert removal of all and tuple. Supply deprecated versions of them as aliases for transposeArray, with a commitment not to drop before 6.0.0 in April 2022, and update the CHANGELOG accordingly.
  • Fix the implementation and naming for transposeMaybe and transposeResult: Maybe.transposeResult now matches the type for Maybe.transposeArray, with a mirrored version for Result.transposeArray.

Supply deprecated versions of them as aliases for `transposeArray`, with
a commitment not to drop before 6.0.0 in April 2022, and update the
CHANGELOG accordingly.
Clarify the names *and* fix the types, so that `Maybe.transposeResult`
matches the type for `Maybe.transposeArray`, with a mirrored version for
`Result.transposeArray`.
@chriskrycho chriskrycho merged commit 072d2b5 into main Nov 27, 2021
@chriskrycho chriskrycho deleted the revert-tuple-all branch November 27, 2021 18:21
@chriskrycho chriskrycho changed the title Revert removal of all and tuple Improve transpose handling Nov 27, 2021
@chriskrycho chriskrycho added this to the v5.0 milestone Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant