[breaking] type-safe Maybe.all implementation
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for implementing #87, remove support for versions prior to TypeScript 4.0, which introduced the variadic tuples type feature required to implement `Maybe.all` and `Maybe.tuple` safely.
- Reimplement `Maybe.all` using variadic tuple types. - Deprecate `Maybe.tuple` as extraneous now that `Maybe.all` can handle both tuples and arrays. Resolves #87
I incorrectly assumed that we would need to explicitly trigger the tuple semantics with `[...U]`, but those semantics are now baked deeply into the compiler's understanding of array types, so we can eliminate the conditional and inferred type in favor of a mapped type, which redistributes the type appropriately over an array or tuple.
bmakuh
reviewed
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe.allusing variadic tuple types.Maybe.tupleas extraneous now thatMaybe.allcan handle both tuples and arrays.Maybe.tupleandMaybe.all#87, remove support for versions prior to TypeScript 4.0, which introduced the variadic tuples type feature required to implementMaybe.allandMaybe.tuplesafely.Resolves #87