You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This code was a very early way to parse functions but it is totally wrong. It has all been subsumed by the monitors, but does have the benefit of not requiring a separate piece of software. In other words remove it, but don't lose the ability to parse a totally arbitrary input data the way ethslurp does. But also don't require a full-fledged monitor program.
In other words--input parsing should happen fully through the ABI if that is the only thing present, but through the parse library if that is what is needed for speed or flexibility. Note that monitors use this code to fill in the [{FUNCTION}] tag.
The text was updated successfully, but these errors were encountered:
tjayrush
changed the title
In parseParams -- you must remove the list of functions and use the ABI to figure out why to do
In transactions.cpp parseParams needs to be removed
Aug 19, 2017
tjayrush
changed the title
In transactions.cpp parseParams needs to be removed
ethslurp: In transactions.cpp parseParams needs to be removed
Jan 30, 2020
From https://github.com/Great-Hill-Corporation/ethslurp/issues/130
This code was a very early way to parse functions but it is totally wrong. It has all been subsumed by the monitors, but does have the benefit of not requiring a separate piece of software. In other words remove it, but don't lose the ability to parse a totally arbitrary input data the way ethslurp does. But also don't require a full-fledged monitor program.
In other words--input parsing should happen fully through the ABI if that is the only thing present, but through the parse library if that is what is needed for speed or flexibility. Note that monitors use this code to fill in the [{FUNCTION}] tag.
The text was updated successfully, but these errors were encountered: