Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethslurp: In transactions.cpp parseParams needs to be removed #42

Closed
tjayrush opened this issue May 6, 2017 · 1 comment
Closed

ethslurp: In transactions.cpp parseParams needs to be removed #42

tjayrush opened this issue May 6, 2017 · 1 comment

Comments

@tjayrush
Copy link
Member

tjayrush commented May 6, 2017

From https://github.com/Great-Hill-Corporation/ethslurp/issues/130

This code was a very early way to parse functions but it is totally wrong. It has all been subsumed by the monitors, but does have the benefit of not requiring a separate piece of software. In other words remove it, but don't lose the ability to parse a totally arbitrary input data the way ethslurp does. But also don't require a full-fledged monitor program.

In other words--input parsing should happen fully through the ABI if that is the only thing present, but through the parse library if that is what is needed for speed or flexibility. Note that monitors use this code to fill in the [{FUNCTION}] tag.

@tjayrush tjayrush self-assigned this May 6, 2017
@tjayrush tjayrush modified the milestone: Release 0.1.0 May 7, 2017
@tjayrush tjayrush changed the title In parseParams -- you must remove the list of functions and use the ABI to figure out why to do In transactions.cpp parseParams needs to be removed Aug 19, 2017
@tjayrush
Copy link
Member Author

tjayrush commented Aug 19, 2017

Referencing closed issue #51
Referencing closed issue #62
Referencing closed issue #73
Referencing closed issue #80

@tjayrush tjayrush added this to To do in Monitors / Scrapers (prior releases) via automation Nov 19, 2018
@tjayrush tjayrush changed the title In transactions.cpp parseParams needs to be removed ethslurp: In transactions.cpp parseParams needs to be removed Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant