Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FAQ link, add issue tracker link #226

Merged
merged 1 commit into from
Mar 6, 2021
Merged

Fix FAQ link, add issue tracker link #226

merged 1 commit into from
Mar 6, 2021

Conversation

banzo
Copy link
Contributor

@banzo banzo commented Mar 5, 2021

Description

  • the previous faq url points to a 404 page, fixed the url (/faq --> /FAQ)
  • Added a link to the Github issue tracker.

Type of change

  • Feature/App addition
  • Bugfix
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor of current code

How Has This Been Tested?

Click on the links in the markdown rendered page.

Notes:

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to this description that prove my fix is effective or that my feature works

@banzo
Fix FAQ link, add issue tracker link
796cad8 
The previous faq url points to a 404 page.
Also added a link to the Github issue tracker.
@banzo banzo requested a review from Ornias1993 as a code owner March 5, 2021 23:22
@Ornias1993 Ornias1993 assigned Ornias1993 and banzo and unassigned Ornias1993 Mar 6, 2021
@Ornias1993 Ornias1993 added bug Something isn't working documentation Improvements or additions to documentation labels Mar 6, 2021
Ornias1993
Ornias1993 approved these changes Mar 6, 2021
View reviewed changes
Copy link
Member

@Ornias1993 Ornias1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for the fix! 👍

@Ornias1993 Ornias1993 merged commit b7bed1c into truecharts:master Mar 6, 2021
Ornias1993 pushed a commit that referenced this pull request Mar 8, 2021
@djs52 @banzo
Add Emby (#221)
467fd98 
* Fix FAQ link, add issue tracker link (#226)

The previous faq url points to a 404 page.
Also added a link to the Github issue tracker.

* Simple Emby chart based on the existing Jellyfin chart

* Set current UID and GID environment variables

* Reset the version to match the other charts

* Clean up incorrect version

* Fix versions and maintainer in Chart.yaml# Please enter the commit message for your changes. Lines starting

* Switch to the linuxserver.io Docker image -- it's more closely matched to other Truecharts

* Add end of file \n

* Add back upstream_version (commented out)

* Update CODEOWNERS

* Update Emby for Truecharts 2.0.0

* Update charts/emby/2.0.0/ix_values.yaml

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* Update charts/emby/2.0.0/test_values.yaml

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* Delete Chart.lock

Co-authored-by: Sebastien Dupont <dupont.sebastien@gmail.com>
Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
Ornias1993 pushed a commit that referenced this pull request Mar 12, 2021
@djs52 @banzo
Add Emby (#221)
3366390 
* Fix FAQ link, add issue tracker link (#226)

The previous faq url points to a 404 page.
Also added a link to the Github issue tracker.

* Simple Emby chart based on the existing Jellyfin chart

* Set current UID and GID environment variables

* Reset the version to match the other charts

* Clean up incorrect version

* Fix versions and maintainer in Chart.yaml# Please enter the commit message for your changes. Lines starting

* Switch to the linuxserver.io Docker image -- it's more closely matched to other Truecharts

* Add end of file \n

* Add back upstream_version (commented out)

* Update CODEOWNERS

* Update Emby for Truecharts 2.0.0

* Update charts/emby/2.0.0/ix_values.yaml

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* Update charts/emby/2.0.0/test_values.yaml

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* Delete Chart.lock

Co-authored-by: Sebastien Dupont <dupont.sebastien@gmail.com>
Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
Ornias1993 pushed a commit that referenced this pull request Mar 17, 2021
@djs52 @banzo
Add Emby (#221)
f8ffc46 
* Fix FAQ link, add issue tracker link (#226)

The previous faq url points to a 404 page.
Also added a link to the Github issue tracker.

* Simple Emby chart based on the existing Jellyfin chart

* Set current UID and GID environment variables

* Reset the version to match the other charts

* Clean up incorrect version

* Fix versions and maintainer in Chart.yaml# Please enter the commit message for your changes. Lines starting

* Switch to the linuxserver.io Docker image -- it's more closely matched to other Truecharts

* Add end of file \n

* Add back upstream_version (commented out)

* Update CODEOWNERS

* Update Emby for Truecharts 2.0.0

* Update charts/emby/2.0.0/ix_values.yaml

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* Update charts/emby/2.0.0/test_values.yaml

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* Delete Chart.lock

Co-authored-by: Sebastien Dupont <dupont.sebastien@gmail.com>
Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
Ornias1993 pushed a commit that referenced this pull request Mar 31, 2021
@banzo
Fix FAQ link, add issue tracker link (#226)
70f6373 
The previous faq url points to a 404 page.
Also added a link to the Github issue tracker.
Ornias1993 pushed a commit that referenced this pull request Mar 31, 2021
@djs52 @banzo
Add Emby (#221)
158729b 
* Fix FAQ link, add issue tracker link (#226)

The previous faq url points to a 404 page.
Also added a link to the Github issue tracker.

* Simple Emby chart based on the existing Jellyfin chart

* Set current UID and GID environment variables

* Reset the version to match the other charts

* Clean up incorrect version

* Fix versions and maintainer in Chart.yaml# Please enter the commit message for your changes. Lines starting

* Switch to the linuxserver.io Docker image -- it's more closely matched to other Truecharts

* Add end of file \n

* Add back upstream_version (commented out)

* Update CODEOWNERS

* Update Emby for Truecharts 2.0.0

* Update charts/emby/2.0.0/ix_values.yaml

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* Update charts/emby/2.0.0/test_values.yaml

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* Delete Chart.lock

Co-authored-by: Sebastien Dupont <dupont.sebastien@gmail.com>
Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
Ornias1993 pushed a commit that referenced this pull request Mar 31, 2021
@banzo
Fix FAQ link, add issue tracker link (#226)
b57adc9 
The previous faq url points to a 404 page.
Also added a link to the Github issue tracker.
Ornias1993 pushed a commit that referenced this pull request Mar 31, 2021
@djs52 @banzo
Add Emby (#221)
e6204cd 
* Fix FAQ link, add issue tracker link (#226)

The previous faq url points to a 404 page.
Also added a link to the Github issue tracker.

* Simple Emby chart based on the existing Jellyfin chart

* Set current UID and GID environment variables

* Reset the version to match the other charts

* Clean up incorrect version

* Fix versions and maintainer in Chart.yaml# Please enter the commit message for your changes. Lines starting

* Switch to the linuxserver.io Docker image -- it's more closely matched to other Truecharts

* Add end of file \n

* Add back upstream_version (commented out)

* Update CODEOWNERS

* Update Emby for Truecharts 2.0.0

* Update charts/emby/2.0.0/ix_values.yaml

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* Update charts/emby/2.0.0/test_values.yaml

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* Delete Chart.lock

Co-authored-by: Sebastien Dupont <dupont.sebastien@gmail.com>
Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
@Ornias1993
Copy link
Member

@all-contributors please add @banzo for doc

@allcontributors allcontributors bot mentioned this pull request Apr 9, 2021
Merged
@allcontributors
Copy link
Contributor

@Ornias1993

I've put up a pull request to add @banzo! 🎉

ellienieuwdorp pushed a commit to ellienieuwdorp/charts that referenced this pull request Apr 10, 2021
@banzo
Fix FAQ link, add issue tracker link (truecharts#226)
66ad8f4 
The previous faq url points to a 404 page.
Also added a link to the Github issue tracker.
ellienieuwdorp pushed a commit to ellienieuwdorp/charts that referenced this pull request Apr 10, 2021
@djs52 @banzo
Add Emby (truecharts#221)
bdd7789 
* Fix FAQ link, add issue tracker link (truecharts#226)

The previous faq url points to a 404 page.
Also added a link to the Github issue tracker.

* Simple Emby chart based on the existing Jellyfin chart

* Set current UID and GID environment variables

* Reset the version to match the other charts

* Clean up incorrect version

* Fix versions and maintainer in Chart.yaml# Please enter the commit message for your changes. Lines starting

* Switch to the linuxserver.io Docker image -- it's more closely matched to other Truecharts

* Add end of file \n

* Add back upstream_version (commented out)

* Update CODEOWNERS

* Update Emby for Truecharts 2.0.0

* Update charts/emby/2.0.0/ix_values.yaml

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* Update charts/emby/2.0.0/test_values.yaml

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* Delete Chart.lock

Co-authored-by: Sebastien Dupont <dupont.sebastien@gmail.com>
Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Jul 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ornias1993 Ornias1993 Ornias1993 approved these changes

Assignees

@banzo banzo

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@banzo @Ornias1993 @truecharts-admin