Add Emby #221

djs52 · 2021-03-05T10:40:10Z

Description

Add Emby Media Server, based on the Jellyfin chart, using the linuxserver.io Docker image. Fixes #64

Type of change

Feature/App addition
Bugfix
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor of current code

How Has This Been Tested?

Installed and running perfectly on TrueNAS-SCALE-21.03-MASTER-20210304-232915

Notes:

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests to this description that prove my fix is effective or that my feature works

Ornias1993

Looks quite good, some small nitpicks. 💯
However, I can't accept this to master, as master does not accept new apps due to the refactor going on.
Accepting this would mean I would directly need to rewrite your questions.yaml, values.yaml and test_values.yaml and I rather focus on getting the refactors done ;-)

Please submit/pr this to "staging" instead. (as requested on the IX forums)

Besides that big thing and the nitpicks, it's quite good.
If it wheren't for the refactor it would be merged already!

Also:
1 more nit:

if you want to be the maintainer, try adding yourself to .github/CODEOWNERS

Upside:
The documentation and testing in the staging branch is much improved for the things that are refactored :)

charts/emby/1.6.3/Chart.yaml

Ornias1993 · 2021-03-05T11:35:47Z

charts/emby/1.6.3/README.md

@@ -0,0 +1,55 @@
+# Introduction


Don't worry about this file, it gets automatically replaced/removed

Should I drop it from the PR?

No it needs to be there, don't worry about it was all I was saying.

Ornias1993 · 2021-03-05T11:35:59Z

charts/emby/1.6.3/app-readme.md

@@ -0,0 +1,2 @@
+Emby Server is a home media server


This file also gets automatically removed/replaced

Ornias1993 · 2021-03-05T11:37:29Z

charts/emby/1.6.3/Chart.yaml

+  - jellyfin
+  - plex


I don't think it's fair to add keywords for totally different solutions...

Heh :) I literally copied this list from the jellyfin chart! I was a bit surprised, but figured it was fair game.

Yeah needs to go there too... thanks for the headsup! :)

charts/emby/item.yaml

djs52 · 2021-03-05T11:59:36Z

Looks quite good, some small nitpicks.
However, I can't accept this to master, as master does not accept new apps due to the refactor going on.
Accepting this would mean I would directly need to rewrite your questions.yaml, values.yaml and test_values.yaml and I rather focus on getting the refactors done ;-)

That's fair. Anything I need to do to prepare this for the post-refactor world?

Please submit/pr this to "staging" instead. (as requested on the IX forums)

Hah, I hadn't even noticed Truecharts had its own thread. Sorry about that, switched the PR over.

Besides that big thing and the nitpicks, it's quite good.

Thanks :)

Ornias1993 · 2021-03-05T15:59:55Z

I'm going to consider this blocked till #219 gets merged into staging...
As thats the second part of the two-part big breaking-change refactor.

Ornias1993 · 2021-03-05T16:00:35Z

charts/emby/1.6.3/Chart.yaml

+  - jellyfin
+  - plex


Yeah needs to go there too... thanks for the headsup! :)

Ornias1993 · 2021-03-05T16:00:45Z

charts/emby/1.6.3/Chart.yaml

+dependencies:
+  - name: common
+    repository: https://charts.truecharts.org/
+    version: 1.6.5
+    # condition:
+    # tags:
+    # import-values:
+    # alias:


for staging this needs to be 2.0.0
(and needs to be manually copied)

Ornias1993 · 2021-03-05T16:01:22Z

charts/emby/1.6.3/README.md

@@ -0,0 +1,55 @@
+# Introduction


No it needs to be there, don't worry about it was all I was saying.

Ornias1993 · 2021-03-05T16:03:08Z

charts/emby/1.6.3/questions.yaml

+
+## TrueCharts Specific
+
+  - variable: appVolumeMounts


Make sure these follow the standardised documented format on the staging branch (.github/docs is the root folder for the docs for now, will be moved on staging to docs/)

Ornias1993 · 2021-03-05T16:03:45Z

charts/emby/1.6.3/questions.yaml

+                schema:
+                  type: string
+
+  - variable: service


Make sure these follow the standardised documented format on the staging branch (.github/docs is the root folder for the docs for now, will be moved on staging to docs/).

This one currently does not.

Ornias1993 · 2021-03-05T16:04:52Z

I should have #219 merged in a day or two, I'll make it my prime priority to merge this as soon as possible afterwards.

Ornias1993 · 2021-03-05T21:31:49Z

Ingress refactor (#219) has been rushed and merged into staging.
You should now have the right documentation and tool you need :)

The previous faq url points to a 404 page. Also added a link to the Github issue tracker.

Ornias1993 · 2021-03-06T20:37:32Z

I managed to sprint #233 into it now too, all big changes have been merged and you should be fine to redo this for the staging branch @djs52 👍

djs52 · 2021-03-06T21:27:12Z

Awesome, thanks! I might not be able to get back to this until Monday, sorry.

Ornias1993 · 2021-03-06T21:28:01Z

@djs52 No problem at all, we all have other things to do too :)

Ornias1993 · 2021-03-08T10:21:09Z

Try not to merge upstream/master into this one, you are really dirtying your PR...
Try rebasing...

Also: Don't submit PR's from your personal master branch, always keep master prestine ;-)

djs52 · 2021-03-08T10:58:01Z

Yeah, I've made a bit of a mess of things. Let me see if I can unpick this, or if I have to recreate the PR from scratch.

…ssage for your changes. Lines starting

…d to other Truecharts

Ornias1993 · 2021-03-08T11:58:56Z

@djs52 No problem, just take your time :)

Ornias1993

Only two little nitpicks :)

Ornias1993 · 2021-03-08T19:05:05Z

charts/emby/2.0.0/Chart.lock

@@ -0,0 +1,6 @@
+dependencies:


remove the lockfile, it's not compatbile (and actually not needed either atm.)

charts/emby/2.0.0/ix_values.yaml

charts/emby/2.0.0/test_values.yaml

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

djs52 · 2021-03-08T19:19:36Z

Done, thanks for your time :)

* Fix FAQ link, add issue tracker link (#226) The previous faq url points to a 404 page. Also added a link to the Github issue tracker. * Simple Emby chart based on the existing Jellyfin chart * Set current UID and GID environment variables * Reset the version to match the other charts * Clean up incorrect version * Fix versions and maintainer in Chart.yaml# Please enter the commit message for your changes. Lines starting * Switch to the linuxserver.io Docker image -- it's more closely matched to other Truecharts * Add end of file \n * Add back upstream_version (commented out) * Update CODEOWNERS * Update Emby for Truecharts 2.0.0 * Update charts/emby/2.0.0/ix_values.yaml Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl> * Update charts/emby/2.0.0/test_values.yaml Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl> * Delete Chart.lock Co-authored-by: Sebastien Dupont <dupont.sebastien@gmail.com> Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

Ornias1993 · 2021-04-09T21:28:11Z

@all-contributors please add @djs52 for code

allcontributors · 2021-04-09T21:28:18Z

@Ornias1993

I've put up a pull request to add @djs52! 🎉

* Fix FAQ link, add issue tracker link (truecharts#226) The previous faq url points to a 404 page. Also added a link to the Github issue tracker. * Simple Emby chart based on the existing Jellyfin chart * Set current UID and GID environment variables * Reset the version to match the other charts * Clean up incorrect version * Fix versions and maintainer in Chart.yaml# Please enter the commit message for your changes. Lines starting * Switch to the linuxserver.io Docker image -- it's more closely matched to other Truecharts * Add end of file \n * Add back upstream_version (commented out) * Update CODEOWNERS * Update Emby for Truecharts 2.0.0 * Update charts/emby/2.0.0/ix_values.yaml Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl> * Update charts/emby/2.0.0/test_values.yaml Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl> * Delete Chart.lock Co-authored-by: Sebastien Dupont <dupont.sebastien@gmail.com> Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

truecharts-admin · 2023-07-09T00:31:23Z

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

djs52 requested a review from Ornias1993 as a code owner March 5, 2021 10:40

Ornias1993 requested changes Mar 5, 2021

View reviewed changes

Ornias1993 added the New App Request label Mar 5, 2021

Ornias1993 assigned djs52 Mar 5, 2021

djs52 changed the base branch from master to staging March 5, 2021 11:54

djs52 requested a review from Ornias1993 March 5, 2021 12:13

Ornias1993 added the Blocked label Mar 5, 2021

Ornias1993 reviewed Mar 5, 2021

View reviewed changes

Ornias1993 removed the Blocked label Mar 5, 2021

Fix FAQ link, add issue tracker link (truecharts#226)

b7bed1c

The previous faq url points to a 404 page. Also added a link to the Github issue tracker.

djs52 force-pushed the master branch from e324c5a to 7a56b8a Compare March 8, 2021 10:55

djs52 added 9 commits March 8, 2021 11:25

Simple Emby chart based on the existing Jellyfin chart

c20314f

Set current UID and GID environment variables

c56ea55

Reset the version to match the other charts

ad646f6

Clean up incorrect version

bfef044

Fix versions and maintainer in Chart.yaml# Please enter the commit me…

b64dc93

…ssage for your changes. Lines starting

Switch to the linuxserver.io Docker image -- it's more closely matche…

7733c67

…d to other Truecharts

Add end of file \n

db2e18f

Add back upstream_version (commented out)

1a7e4fe

Update CODEOWNERS

e174584

djs52 force-pushed the master branch from 7a56b8a to e174584 Compare March 8, 2021 11:29

Update Emby for Truecharts 2.0.0

6b35cb5

djs52 requested a review from Ornias1993 March 8, 2021 15:14

Ornias1993 requested changes Mar 8, 2021

View reviewed changes

djs52 and others added 3 commits March 8, 2021 19:17

Update charts/emby/2.0.0/ix_values.yaml

f5100b2

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

Update charts/emby/2.0.0/test_values.yaml

af3a982

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

Delete Chart.lock

653e583

djs52 requested a review from Ornias1993 March 8, 2021 19:21

Ornias1993 approved these changes Mar 8, 2021

View reviewed changes

Ornias1993 merged commit 467fd98 into truecharts:staging Mar 8, 2021

allcontributors bot mentioned this pull request Apr 9, 2021

docs: add djs52 as a contributor #309

Merged

truecharts locked as resolved and limited conversation to collaborators Jul 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Emby #221

Add Emby #221

djs52 commented Mar 5, 2021 •

edited by Ornias1993

Ornias1993 left a comment •

edited

Ornias1993 Mar 5, 2021

djs52 Mar 5, 2021

Ornias1993 Mar 5, 2021

Ornias1993 Mar 5, 2021

Ornias1993 Mar 5, 2021

djs52 Mar 5, 2021

Ornias1993 Mar 5, 2021

djs52 commented Mar 5, 2021

Ornias1993 commented Mar 5, 2021

Ornias1993 Mar 5, 2021

Ornias1993 Mar 5, 2021

Ornias1993 Mar 5, 2021

Ornias1993 Mar 5, 2021

Ornias1993 Mar 5, 2021

Ornias1993 commented Mar 5, 2021

Ornias1993 commented Mar 5, 2021

Ornias1993 commented Mar 6, 2021 •

edited

djs52 commented Mar 6, 2021

Ornias1993 commented Mar 6, 2021

Ornias1993 commented Mar 8, 2021 •

edited

djs52 commented Mar 8, 2021

Ornias1993 commented Mar 8, 2021

Ornias1993 left a comment

Ornias1993 Mar 8, 2021

djs52 commented Mar 8, 2021

Ornias1993 commented Apr 9, 2021

allcontributors bot commented Apr 9, 2021

truecharts-admin commented Jul 9, 2023

Add Emby #221

Add Emby #221

Conversation

djs52 commented Mar 5, 2021 • edited by Ornias1993

Ornias1993 left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

djs52 commented Mar 5, 2021

Ornias1993 commented Mar 5, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ornias1993 commented Mar 5, 2021

Ornias1993 commented Mar 5, 2021

Ornias1993 commented Mar 6, 2021 • edited

djs52 commented Mar 6, 2021

Ornias1993 commented Mar 6, 2021

Ornias1993 commented Mar 8, 2021 • edited

djs52 commented Mar 8, 2021

Ornias1993 commented Mar 8, 2021

Ornias1993 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

djs52 commented Mar 8, 2021

Ornias1993 commented Apr 9, 2021

allcontributors bot commented Apr 9, 2021

truecharts-admin commented Jul 9, 2023

djs52 commented Mar 5, 2021 •

edited by Ornias1993

Ornias1993 left a comment •

edited

Ornias1993 commented Mar 6, 2021 •

edited

Ornias1993 commented Mar 8, 2021 •

edited