Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update minecraft-java docker image version #4166

Closed
wants to merge 1 commit into from

Conversation

boyphongsakorn
Copy link

@boyphongsakorn boyphongsakorn commented Oct 23, 2022

Description
⚒️ Fixes # if REMOVE_OLD_MODS = true redownload plugins

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:
BIG CHANGE OF THIS VERSION IS when i environment variables REMOVE_OLD_MODS is True or manually remove plugin, it remove plugin but not redownload plugins from env SPIGET_RESOURCES because version meta data is still and it same version in spigot/spiget, it will not redownload itzg/docker-minecraft-server#1792 (comment)

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🪞 I have opened a PR on truecharts/containers adding the container to TrueCharts mirror repo.
  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

Signed-off-by: Phongsakorn Wisetthon <boy1556@hotmail.com>
@CLAassistant
Copy link

CLAassistant commented Oct 23, 2022

CLA assistant check
All committers have signed the CLA.

@truecharts-admin truecharts-admin added the size/XS Categorises a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2022
@xstar97
Copy link
Contributor

xstar97 commented Oct 23, 2022

we only build the installer...if any changes to the upstream has happen its going to be a few days or a while for our automations to pick up the new version automatically...this PR is basically smoke at this point.

edit
our automations has auto-grabbed it yesterday -> #4165

@truecharts-admin truecharts-admin added precommit:ok CI status: pre-commit validation successful lint:ok CI status: linting successful install:ok CI status: install successful labels Oct 23, 2022
@boyphongsakorn
Copy link
Author

we only build the installer...if any changes to the upstream has happen its going to be a few days or a while for our automations to pick up the new version automatically...this PR is basically smoke at this point.

edit our automations has auto-grabbed it yesterday -> #4165

oh ok

@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
install:ok CI status: install successful lint:ok CI status: linting successful precommit:ok CI status: pre-commit validation successful size/XS Categorises a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants