Skip to content

if REMOVE_OLD_MODS = true redownload plugins #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 22, 2022
Merged

if REMOVE_OLD_MODS = true redownload plugins #1792

merged 3 commits into from
Oct 22, 2022

Conversation

@boyphongsakorn
Copy link
Contributor

@boyphongsakorn boyphongsakorn commented Oct 18, 2022 •
edited
Loading

if REMOVE_OLD_MODS is True
set installedVersion = 0.0.0

@itzg
Copy link
Owner

itzg commented Oct 18, 2022

Please provide a description on PRs. I can't review this until I know what problem was being solved.

@boyphongsakorn
Copy link
Contributor Author

boyphongsakorn commented Oct 19, 2022

Please provide a description on PRs. I can't review this until I know what problem was being solved.

ok, i add it.

@itzg
Copy link
Owner

itzg commented Oct 19, 2022 •
edited
Loading

That doesn't help at all.

What I want to know is: why are you proposing this change? Container config attempted? Expected results? Opening an issue first for discussion would have been good.

@boyphongsakorn
Copy link
Contributor Author

boyphongsakorn commented Oct 19, 2022 •
edited
Loading

why are you proposing this change? Container config attempted? Expected results? Opening an issue first for discussion would have been good.

when i environment variables REMOVE_OLD_MODS is True or manually remove plugin, it remove plugin but not redownload plugins from env SPIGET_RESOURCES because version meta data is still and it same version in spigot/spiget, it will not redownload

@itzg
Copy link
Owner

itzg commented Oct 19, 2022

Thank you. That is a good reason for the change.

itzg
itzg approved these changes Oct 22, 2022
View reviewed changes
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay getting back to this. The changes look great for the problem solved.

@itzg itzg merged commit ad912fe into itzg:master Oct 22, 2022
@itzg itzg added the bug label Oct 22, 2022
This was referenced Oct 23, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itzg itzg itzg approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@boyphongsakorn @itzg