Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] default REGEX_EMAIL_PATTERN is incorrect #7

Closed
AlexeyDemidov opened this issue Mar 25, 2019 · 1 comment
Closed

[BUG] default REGEX_EMAIL_PATTERN is incorrect #7

AlexeyDemidov opened this issue Mar 25, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@AlexeyDemidov
Copy link

Default REGEX_EMAIL_PATTERN for local part of email address allows only very limited set of characters and rejects many valid email addresses. The most common example is + sign which is commonly used for sub-addressing, but local part of email address can include much wider range of printable characters, e.g. !#$%&'*+-/=?^_{|}~. At the same time default regex allows local part of address to start with a dot .` which is prohibited by the standard. There is also issue that quoting of local part is unsupported by the default regex. Please see RFC 5322, sec. 3.4.1 for detailed email address specification.

@bestwebua bestwebua added the bug Something isn't working label Mar 27, 2019
@bestwebua bestwebua self-assigned this Mar 27, 2019
bestwebua added a commit that referenced this issue Mar 27, 2019
bestwebua added a commit that referenced this issue Mar 27, 2019
* Fix regex issues: #7, #8, #9
* Update tests
@bestwebua
Copy link
Member

👍 Add cases with dot and +. Also user can override default pattern.

@bestwebua bestwebua changed the title default REGEX_EMAIL_PATTERN is incorrect [BUG] default REGEX_EMAIL_PATTERN is incorrect Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants