-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-110243 / 21.06 / Allow endpoints to specify explicit http methods #6802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
Allow endpoints to specify explicit http methods
NAS-110243 / 21.04 / Allow endpoints to specify explicit http methods
Apr 22, 2021
sonicaj
changed the title
NAS-110243 / 21.04 / Allow endpoints to specify explicit http methods
NAS-110243 / 21.06 / Allow endpoints to specify explicit http methods
Apr 22, 2021
william-gr
reviewed
Apr 22, 2021
william-gr
reviewed
Apr 22, 2021
sonicaj
force-pushed
the
NAS-110243
branch
2 times, most recently
from
April 22, 2021 18:25
9e99527
to
2b3bc3e
Compare
I would remove the "explicit", but thats just me :P |
Done :D |
william-gr
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when we want to maintain backwards compatibility with endpoints which were not expecting payload before but are now and users still would like to consume them with previous method which would be GET whereas it's POST now.