Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-110243 / 21.06 / Allow endpoints to specify explicit http methods #6802

Merged
merged 2 commits into from
Apr 26, 2021

Conversation

sonicaj
Copy link
Member

@sonicaj sonicaj commented Apr 22, 2021

This is useful when we want to maintain backwards compatibility with endpoints which were not expecting payload before but are now and users still would like to consume them with previous method which would be GET whereas it's POST now.

@sonicaj sonicaj requested a review from a team April 22, 2021 17:56
@sonicaj sonicaj self-assigned this Apr 22, 2021
@bugclerk bugclerk changed the title Allow endpoints to specify explicit http methods NAS-110243 / 21.04 / Allow endpoints to specify explicit http methods Apr 22, 2021
@bugclerk
Copy link
Contributor

@sonicaj sonicaj changed the title NAS-110243 / 21.04 / Allow endpoints to specify explicit http methods NAS-110243 / 21.06 / Allow endpoints to specify explicit http methods Apr 22, 2021
@sonicaj sonicaj requested a review from william-gr April 22, 2021 18:24
@sonicaj sonicaj force-pushed the NAS-110243 branch 2 times, most recently from 9e99527 to 2b3bc3e Compare April 22, 2021 18:25
@william-gr
Copy link
Member

I would remove the "explicit", but thats just me :P

@sonicaj
Copy link
Member Author

sonicaj commented Apr 22, 2021

Done :D

@sonicaj sonicaj requested a review from a team April 23, 2021 21:44
Copy link
Member

@william-gr william-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants