NAS-120362 / Ensure that commonly requested xattrs are in SA #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have SA-based xattrs on FreeBSD we should ensure that certain important samba-related xattrs are written to this area rather than in the xattr dir. This avoids having to perform more expensive permissions check, lookup, and read. Since we can't always know what the contents of these xattrs will be beforehand, store empty xattrs and have Samba internally assign special meaning to the ones with no value (e.g. fail read with ENOATTR). This is sufficient to mask the attributes from SMB clients since vfs_streams_xattr will attempt to FGETXATTR prior to appending the xattr to STREAM_INFO response. Three attributes to be stored in this way are: - user.DOSATTRIB (always requested for files) - stream (AFP_AfpInfo) which is used by VFS fruit to generate response to SMB2 FIND_INFO requests when AAPL context negotiated. - stream (AFP_Resource) which is requested by Finder to check for metadata related to icons or other usage of resource forks.
anodos325
force-pushed
the
NAS-120362
branch
from
88dbee0
to
77a83a3
Compare
yocalebo
reviewed
Feb 16, 2023
| struct streams_xattr_config *config) | ||
| { | ||
| if ((strcmp(name, SAMBA_XATTR_DOS_ATTRIB) == 0) || | ||
| (strcmp(name, config->afpinfo_name) == 0) || |
There was a problem hiding this comment.
Do these elements in the struct get checked for NULL before it reaches this function? I presume they do.
There was a problem hiding this comment.
gets checked in streams_xattr_connect()
if (config->afpresource_name == NULL) {
DBG_ERR("talloc_asprintf() failed\n");
return -1;
}
If tree connect fails, then session won't get this far.
anodos325
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have SA-based xattrs on FreeBSD we should ensure that certain important samba-related xattrs are written to this area rather than in the xattr dir. This avoids having to perform more expensive permissions check, lookup, and read.
Since we can't always know what the contents of these xattrs will be beforehand, store empty xattrs and have Samba internally assign special meaning to the ones with no value (e.g. fail read with ENOATTR). This is sufficient to mask the attributes from SMB clients since vfs_streams_xattr will attempt to FGETXATTR prior to appending the xattr to STREAM_INFO response.
Three attributes to be stored in this way are: