Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-128625 / 24.10 / Recent searches in global search shows unusual results #10007

Merged
merged 3 commits into from Apr 30, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket, try to update local storagerecentSearches, add unexisting search result. (update hierarchy item)

You should only see items which are available in ui-searchable-elements.json.

@AlexKarpov98 AlexKarpov98 self-assigned this Apr 29, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner April 29, 2024 13:36
@AlexKarpov98 AlexKarpov98 requested review from RehanY147 and removed request for a team April 29, 2024 13:36
@bugclerk bugclerk changed the title NAS-128625: Recent searches in global search shows unusual results NAS-128625 / 24.10 / Recent searches in global search shows unusual results Apr 29, 2024
@bugclerk
Copy link
Contributor

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old search results are gone.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.50%. Comparing base (7b2e738) to head (0697ca6).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10007      +/-   ##
==========================================
+ Coverage   73.44%   73.50%   +0.05%     
==========================================
  Files        1499     1501       +2     
  Lines       52599    52642      +43     
  Branches     6278     6284       +6     
==========================================
+ Hits        38632    38692      +60     
+ Misses      13967    13950      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexKarpov98 AlexKarpov98 merged commit c5e6a29 into master Apr 30, 2024
10 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-128625 branch April 30, 2024 09:42
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants