NAS-128625 / 24.10 / Recent searches in global search shows unusual results

src/app/modules/global-search/components/global-search/global-search.component.spec.ts

@@ -137,7 +137,7 @@ describe('GlobalSearchComponent', () => {
     spectator.component.resetInput();
     spectator.detectChanges();
 
-    expect(spectator.component.searchControl.value).toBeNull();
+    expect(spectator.component.searchControl.value).toBe('');
     expect(document.activeElement).toBe(spectator.query('input'));
   });
 });

src/app/modules/global-search/components/global-search/global-search.component.ts

@@ -82,7 +82,7 @@ export class GlobalSearchComponent implements OnInit {
   }
 
   resetInput(): void {
-    this.searchControl.reset();
+    this.searchControl.setValue('');
   }
 
   private listenForSearchChanges(): void {

src/app/modules/global-search/services/global-search-sections.service.spec.ts

@@ -6,6 +6,19 @@ import { GlobalSearchSection } from 'app/modules/global-search/enums/global-sear
 import { GlobalSearchSectionsProvider } from 'app/modules/global-search/services/global-search-sections.service';
 import { UiSearchProvider } from 'app/modules/global-search/services/ui-search.service';
 
+jest.mock('app/../assets/ui-searchable-elements.json', () => ([
+  {
+    hierarchy: ['search1'],
+    synonyms: [],
+    requiredRoles: [],
+    anchorRouterLink: [],
+    routerLink: null,
+    anchor: 'some-anchor',
+    triggerAnchor: null,
+    section: GlobalSearchSection.Ui,
+  },
+]));
+
 describe('GlobalSearchSectionsProvider', () => {
   let spectator: SpectatorService<GlobalSearchSectionsProvider>;
   const mockLocalStorage = {
@@ -25,7 +38,9 @@ describe('GlobalSearchSectionsProvider', () => {
     ],
   });
 
-  beforeEach(() => spectator = createService());
+  beforeEach(() => {
+    spectator = createService();
+  });
 
   it('should fetch UI section results based on search term', () => {
     const searchTerm = 'test';
@@ -60,13 +75,28 @@ describe('GlobalSearchSectionsProvider', () => {
     }]);
   });
 
-  it('should retrieve recent searches from localStorage', () => {
-    const recentSearches = [{ hierarchy: ['search1'], targetHref: 'url1', section: '' }];
+  // ui-searchable-elements.json is mocked above
+  it('should retrieve recent searches from localStorage and remove outdated items from local storage if any', () => {
+    const recentSearches = [
+      {
+        hierarchy: ['search1'], // existing hierarchy
+        targetHref: 'url1',
+      },
+      {
+        hierarchy: ['search to be removed'], // non-existing hierarchy
+        targetHref: 'url2',
+      },
+    ];
+
     mockLocalStorage.getItem.mockReturnValue(JSON.stringify(recentSearches));
 
     const results = spectator.service.getRecentSearchesSectionResults();
 
     expect(mockLocalStorage.getItem).toHaveBeenCalledWith('recentSearches');
-    expect(results).toEqual(recentSearches);
+    expect(mockLocalStorage.setItem).toHaveBeenCalledWith('recentSearches', JSON.stringify([recentSearches[0]]));
+
+    expect(results).toEqual([
+      recentSearches[0],
+    ]);
   });
 });

src/app/modules/global-search/services/global-search-sections.service.ts

@@ -1,5 +1,6 @@
 import { Inject, Injectable } from '@angular/core';
 import { TranslateService } from '@ngx-translate/core';
+import UiElementsJson from 'app/../assets/ui-searchable-elements.json';
 import { Observable } from 'rxjs';
 import { WINDOW } from 'app/helpers/window.helper';
 import { GlobalSearchSection } from 'app/modules/global-search/enums/global-search-section.enum';
@@ -41,6 +42,17 @@ export class GlobalSearchSectionsProvider {
   }
 
   getRecentSearchesSectionResults(): UiSearchableElement[] {
-    return JSON.parse(this.window.localStorage.getItem('recentSearches') || '[]');
+    const recentSearches = JSON.parse(this.window.localStorage.getItem('recentSearches') || '[]') as UiSearchableElement[];
+    const exitingHierarchies = new Set(UiElementsJson.map((item) => JSON.stringify(item.hierarchy)));
+
+    const validRecentSearches = recentSearches.filter((item) => {
+      return exitingHierarchies.has(JSON.stringify(item.hierarchy)) || item.hierarchy[0].startsWith('Search Documentation for');
+    });
+
+    if (recentSearches.length !== validRecentSearches.length) {
+      this.window.localStorage.setItem('recentSearches', JSON.stringify(validRecentSearches));
+    }
+
+    return validRecentSearches;
   }
 }