Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button action vs link-to #163

Closed
basz opened this issue Jul 3, 2015 · 3 comments
Closed

Button action vs link-to #163

basz opened this issue Jul 3, 2015 · 3 comments

Comments

@basz
Copy link
Contributor

basz commented Jul 3, 2015

Would it be desirable for the btn component to be able to transition to routes instead of utilizing its action?

Why? Actions are not SEO friendly. Convenience.

eg.

{{#md-btn action='link-to' actionArg='some.route' icon='fa fa-sign-in'}}go somewhere{{/md-btn}}

or

{{#md-btn linkTo='some.route' icon='fa fa-sign-in'}}go somewhere{{/md-btn}}

or possibly, which would do the action ping and then transition with a post model

{{#md-btn action='ping'  linkTo='some.route' linkToArgs='post' icon='fa fa-sign-in'}}go somewhere{{/md-btn}}

Just checking if that's doable without to much problems? Perhaps the md-btn could extend the link-to helper easely?

@mike-north
Copy link
Owner

maybe we need a new component like {{md-btn-to}} or something? I'm a little wary of trying to make one component usable in too many ways.

What are your thoughts?

@basz
Copy link
Contributor Author

basz commented Jul 3, 2015

i agree, becomes complicated quickly

@mike-north
Copy link
Owner

mike-north commented Jul 31, 2016

This is handled in #292, and will be released with 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants